Changeset f7221df in github

Timestamp:

Dec 28, 2010 2:17:32 AM (2 years ago)

Author:

alecpl <alec@…>

Branches:

master, HEAD, courier-fix, dev-browser-capabilities, pdo, release-0.6, release-0.7, release-0.8

Children:

d70c217

Parents:

a63b36a

Message:

• Fix for ANNOTATEMORE drafts below 08 version (use quoted parameters)

File:

• program/include/rcube_imap_generic.php (modified) (5 diffs)

program/include/rcube_imap_generic.php

@@ -2882 +2882 @@
             }
 
+            // ANNOTATEMORE drafts before version 08 require quoted parameters
             $entries[] = sprintf('%s (%s %s)',
-                $this->escape($name), $this->escape($attr), $value);
+                $this->escape($name, true), $this->escape($attr, true), $value);
         }
 
@@ -2933 +2934 @@
         }
         // create entries string
+        // ANNOTATEMORE drafts before version 08 require quoted parameters
         foreach ($entries as $idx => $name) {
-            $entries[$idx] = $this->escape($name);
+            $entries[$idx] = $this->escape($name, true);
         }
         $entries = '(' . implode(' ', $entries) . ')';
@@ -2943 +2945 @@
         // create entries string
         foreach ($attribs as $idx => $name) {
-            $attribs[$idx] = $this->escape($name);
+            $attribs[$idx] = $this->escape($name, true);
         }
         $attribs = '(' . implode(' ', $attribs) . ')';
@@ -3238 +3240 @@
      * Escapes a string when it contains special characters (RFC3501)
      *
-     * @param string $string IMAP string
+     * @param string  $string       IMAP string
+     * @param boolean $force_quotes Forces string quoting
      *
      * @return string Escaped string
      * @todo String literals, lists
      */
-    static function escape($string)
+    static function escape($string, $force_quotes=false)
     {
         if ($string === null) {
@@ -3251 +3254 @@
             return '""';
         }
-        else if (preg_match('/([\x00-\x20\x28-\x29\x7B\x25\x2A\x22\x5C\x5D\x7F]+)/', $string)) {
+        else if ($force_quotes ||
+            preg_match('/([\x00-\x20\x28-\x29\x7B\x25\x2A\x22\x5C\x5D\x7F]+)/', $string)
+        ) {
             // string: special chars: SP, CTL, (, ), {, %, *, ", \, ]
             return '"' . strtr($string, array('"'=>'\\"', '\\' => '\\\\')) . '"';