Changeset b620493a in github

Timestamp:

Feb 5, 2010 6:35:11 AM (3 years ago)

Author:

alecpl <alec@…>

Branches:

master, HEAD, courier-fix, dev-browser-capabilities, pdo, release-0.6, release-0.7, release-0.8

Children:

f6b145d

Parents:

ad18d63

Message:

• Fix quoted text wrapping when replying to an HTML email in plain text (#1484141)

Files:

• CHANGELOG (modified) (1 diff)
• program/steps/mail/compose.inc (modified) (6 diffs)
• program/steps/mail/sendmail.inc (modified) (3 diffs)

CHANGELOG

@@ -2 +2 @@
 ===========================
 
+- Fix quoted text wrapping when replying to an HTML email in plain text (#1484141)
 - Fix handling of extended mailto links (with params) (#1486354)
 - Fix sorting by date of messages without date header on servers without SORT (#1486286)

program/steps/mail/compose.inc

@@ -129 +129 @@
   $OUTPUT->set_env('show_sig', false);
 
+// set line length for body wrapping
+$LINE_LENGTH = $RCMAIL->config->get('line_length', 75);
+
 if (!empty($msg_uid))
 {
   // similar as in program/steps/mail/show.inc
   // re-set 'prefer_html' to have possibility to use html part for compose
-  $CONFIG['prefer_html'] = $CONFIG['htmleditor'] || $compose_mode == RCUBE_COMPOSE_DRAFT || $compose_mode == RCUBE_COMPOSE_EDIT;
+  $CONFIG['prefer_html'] = $CONFIG['prefer_html'] || $CONFIG['htmleditor'] || $compose_mode == RCUBE_COMPOSE_DRAFT || $compose_mode == RCUBE_COMPOSE_EDIT;
   $MESSAGE = new rcube_message($msg_uid);
   
@@ -396 +399 @@
 function rcmail_compose_body($attrib)
 {
-  global $RCMAIL, $CONFIG, $OUTPUT, $MESSAGE, $compose_mode;
+  global $RCMAIL, $CONFIG, $OUTPUT, $MESSAGE, $compose_mode, $LINE_LENGTH;
   
   list($form_start, $form_end) = get_form_tags($attrib);
@@ -425 +428 @@
   else if ($compose_mode)
   {
-    if (($isHtml || $compose_mode == RCUBE_COMPOSE_DRAFT) && $MESSAGE->has_html_part())
+    $has_html_part = $MESSAGE->has_html_part();
+    if (($isHtml || $compose_mode == RCUBE_COMPOSE_DRAFT) && $has_html_part)
     {
       $body = $MESSAGE->first_html_part();
       $isHtml = true;
+    }
+    else if ($has_html_part)
+    {
+      // use html part if it has been used for message (pre)viewing
+      // decrease line length for quoting
+      $len = $compose_mode == RCUBE_COMPOSE_REPLY ? $LINE_LENGTH-2 : $LINE_LENGTH;
+      $txt = new html2text($MESSAGE->first_html_part(), false, true, $len);
+      $body = $txt->get_text();
+      $isHtml = false;
     }
     else
@@ -523 +536 @@
 function rcmail_create_reply_body($body, $bodyIsHtml)
 {
-  global $RCMAIL, $MESSAGE;
+  global $RCMAIL, $MESSAGE, $LINE_LENGTH;
 
   if (!$bodyIsHtml) {
@@ -533 +546 @@
 
     // soft-wrap message first
-    $body = rcmail_wrap_quoted($body, 75);
+    $body = rcmail_wrap_quoted($body, $LINE_LENGTH);
 
     $body = rtrim($body, "\r\n");
@@ -555 +568 @@
     $prefix = rc_wordwrap(sprintf("On %s, %s wrote:\n",
       $MESSAGE->headers->date,
-      $MESSAGE->get_header('from')), 76);
+      $MESSAGE->get_header('from')), $LINE_LENGTH);
 
     $suffix = '';

program/steps/mail/sendmail.inc

@@ -358 +358 @@
 }
 
+// set line length for body wrapping
+$LINE_LENGTH = $RCMAIL->config->get('line_length', 75);
+
 // create extended PEAR::Mail_mime instance
 $MAIL_MIME = new rcube_mail_mime($RCMAIL->config->header_delimiter());
@@ -370 +373 @@
   // add a plain text version of the e-mail as an alternative part.
   $h2t = new html2text($plugin['body'], false, true, 0);
-  $plainTextPart = rc_wordwrap($h2t->get_text(), 75, "\r\n") . ($footer ? "\r\n".$footer : '');
+  $plainTextPart = rc_wordwrap($h2t->get_text(), $LINE_LENGTH, "\r\n") . ($footer ? "\r\n".$footer : '');
   $plainTextPart = wordwrap($plainTextPart, 998, "\r\n", true);
   if (!strlen($plainTextPart)) {
@@ -384 +387 @@
 else
   {
-  $message_body = rc_wordwrap($message_body, 75, "\r\n");
+  $message_body = rc_wordwrap($message_body, $LINE_LENGTH, "\r\n");
   if ($footer)
     $message_body .= "\r\n" . $footer;