Changeset b37e698 in github

Timestamp:

Dec 23, 2010 6:21:16 AM (2 years ago)

Author:

thomascube <thomas@…>

Branches:

master, HEAD, courier-fix, dev-browser-capabilities, pdo, release-0.6, release-0.7, release-0.8

Children:

ceb7085

Parents:

7c9850d

Message:

Show the same message only once; increase display time for warnings

Files:

• CHANGELOG (modified) (1 diff)
• program/js/app.js (modified) (5 diffs)

CHANGELOG

@@ -1 +1 @@
 CHANGELOG Roundcube Webmail
 ===========================
+
+- Show the same message only once (#1487641)
 
 RELEASE 0.5-RC

program/js/app.js

@@ -38 +38 @@
   // webmail client settings
   this.dblclick_time = 500;
-  this.message_time = 1500;
+  this.message_time = 2000;
 
   this.identifier_expr = new RegExp('[^0-9a-z\-_]', 'gi');
@@ -4521 +4521 @@
     type = type ? type : 'notice';
 
-    var date = new Date(),
-      id = type + date.getTime();
-
-    if (type == 'loading') {
-      if (!msg)
-        msg = this.get_label('loading');
-
-      // The same message of type 'loading' is already displayed
-      if (this.messages[msg]) {
-        this.messages[msg].elements.push(id);
-        return id;
-      }
-    }
-
     var ref = this,
-      obj = $('<div>').addClass(type).html(msg),
+      date = new Date(),
+      id = type + date.getTime(),
+      timeout = type == 'loading' ? this.env.request_timeout * 1000 : (this.message_time * (type == 'error' || type == 'warning' ? 2 : 1));
+
+    if (type == 'loading' && !msg)
+      msg = this.get_label('loading');
+
+    // The same message is already displayed
+    if (this.messages[msg]) {
+      this.messages[msg].elements.push(id);
+      window.setTimeout(function() { ref.hide_message(id, true); }, timeout);
+      return id;
+    }
+
+    var obj = $('<div>').addClass(type).html(msg).data('msg', msg),
       cont = $(this.gui_objects.message).show();
 
@@ -4542 +4542 @@
       obj.appendTo(cont);
       this.messages[msg] = {'obj': obj, 'elements': [id]};
-      window.setTimeout(function() { rcmail.hide_message(id); }, this.env.request_timeout * 1000);
+      window.setTimeout(function() { rcmail.hide_message(id); }, timeout);
       return id;
     }
     else {
-      obj.appendTo(cont).bind('mousedown', function() { return ref.hide_message(obj); });
-      window.setTimeout(function() { ref.hide_message(obj, true); },
-        this.message_time * (type == 'error' ? 2 : 1));
-      return obj;
+      obj.appendTo(cont).bind('mousedown', function() { return ref.hide_message(obj, true); });
+      window.setTimeout(function() { ref.hide_message(id, true); }, timeout);
+      this.messages[msg] = { 'obj': obj, 'elements': [id] };
+      return id;
     }
   };
@@ -4561 +4561 @@
 
     if (typeof(obj) == 'object') {
-      // custom message
+      // hide message object
       $(obj)[fade?'fadeOut':'hide']();
+      
+      var msg = $(obj).data('msg');
+      if (this.messages[msg])
+        delete this.messages[msg];
     }
     else {
-      // 'loading' message
+      // hide message by id
       var k, n, m = this.messages;
       for (k in m) {
@@ -4571 +4575 @@
           if (m[k] && m[k].elements[n] == obj) {
             m[k].elements.splice(n, 1);
+            // hide dom element if last instance is removed
             if (!m[k].elements.length) {
               m[k].obj[fade?'fadeOut':'hide']();