Changeset a98ee35 in github

Timestamp:

Aug 26, 2011 5:22:53 AM (22 months ago)

Author:

alecpl <alec@…>

Branches:

master, HEAD, courier-fix, dev-browser-capabilities, pdo, release-0.7, release-0.8

Children:

20ed379

Parents:

da71783

Message:

• Microoptimization: use substr_replace() for injecting a string into string

File:

• program/include/rcube_html_page.php (modified) (5 diffs)

program/include/rcube_html_page.php

@@ -213 +213 @@
             $this->add_script('$(document).ready(function(){ ' . $this->scripts['docready'] . "\n});", 'foot');
         }
-        
+
         if (is_array($this->script_files['foot'])) {
             foreach ($this->script_files['foot'] as $file) {
@@ -247 +247 @@
         // add page hader
         if ($hpos) {
-            $output = substr($output,0,$hpos) . $page_header . substr($output,$hpos,strlen($output));
+            $output = substr_replace($output, $page_header, $hpos, 0);
         }
         else {
@@ -255 +255 @@
         // add page footer
         if (($fpos = strripos($output, '</body>')) || ($fpos = strripos($output, '</html>'))) {
-            $output = substr($output, 0, $fpos) . "$page_footer\n" . substr($output, $fpos);
+            $output = substr_replace($output, $page_footer."\n", $fpos, 0);
         }
         else {
@@ -269 +269 @@
                 $css .= sprintf($this->link_css_file, $file);
             }
-            $output = substr($output, 0, $pos) . $css . substr($output, $pos);
+            $output = substr_replace($output, $css, $pos, 0);
         }
 
@@ -290 +290 @@
         }
     }
-    
+
     /**
      * Callback function for preg_replace_callback in write()