Changeset a4e71c5 in github

Timestamp:

Feb 1, 2012 2:40:30 AM (16 months ago)

Author:

thomascube <thomas@…>

Branches:

master, HEAD, courier-fix, dev-browser-capabilities, pdo, release-0.8

Children:

3a86e267

Parents:

6835114

Message:

Improve tabs and splitter functionality

File:

• skins/larry/ui.js (modified) (5 diffs)

skins/larry/ui.js

@@ -713 +713 @@
   function init_tabs(elem, current)
   {
-    var id = elem.id,
-      content = $(elem),
+    var content = $(elem),
+      id = content.get(0).id,
       fs = content.children('fieldset');
 
@@ -722 +722 @@
     if (!id) {
       id = 'rcmtabcontainer';
-      elem.attr('id', id);
+      content.attr('id', id);
     }
 
@@ -799 +799 @@
 
 /**
- * Roundcube splitter GUI class
+ * Roundcube UI splitter class
  *
  * @constructor
@@ -824 +824 @@
     this.p2 = $(this.p.p2);
 
+    // check if referenced elements exist, otherwise abort
+    if (!this.p1.length || !this.p2.length)
+      return;
+
     // create and position the handle for this splitter
     this.p1pos = this.relative ? this.p1.position() : this.p1.offset();
@@ -843 +847 @@
     }
 
-    this.elm = this.handle.get(0);
-
     // listen to window resize on IE
     if (bw.ie)
-      $(window).resize(function(e){ onResize(e) });
+      $(window).resize(onResize);
 
     // read saved position from cookie