Changeset a1013c0 in github

Timestamp:

Jan 10, 2011 9:50:48 AM (2 years ago)

Author:

thomascube <thomas@…>

Branches:

master, HEAD, courier-fix, dev-browser-capabilities, pdo, release-0.6, release-0.7, release-0.8

Children:

00e18b7

Parents:

0ff554d

Message:

Exclude punctuation from URLs within text; only link accepted url schemes

Files:

• program/include/rcube_string_replacer.php (modified) (2 diffs)
• tests/mailfunc.php (modified) (1 diff)
• tests/src/plainbody.txt (modified) (1 diff)

program/include/rcube_string_replacer.php

@@ -38 +38 @@
     // Simplified domain expression for UTF8 characters handling
     $utf_domain = '[^?&@"\'\\/()\s\r\t\n]+\\.[a-z]{2,5}';
-    $url = '[a-z0-9%=#@+?.:;&\\/_~\\[\\]-]+';
+    $url1 = '.:;';
+    $url2 = 'a-z0-9%=#@+?&\\/_~\\[\\]-';
 
-    $this->link_pattern = "/([\w]+:\/\/|\Wwww\.)($utf_domain($url)?)/i";
+    $this->link_pattern = "/([\w]+:\/\/|\Wwww\.)($utf_domain([$url1]?[$url2]+)*)/i";
     $this->mailto_pattern = "/("
         ."[-\w!\#\$%&\'*+~\/^`|{}=]+(?:\.[-\w!\#\$%&\'*+~\/^`|{}=]+)*"  // local-part
         ."@$utf_domain"                                                 // domain-part
-        ."(\?$url)?"                                                    // e.g. ?subject=test...
+        ."(\?[$url1$url2]+)?"                                           // e.g. ?subject=test...
         .")/i";
   }
@@ -89 +90 @@
     }
 
-    $suffix = $this->parse_url_brackets($url);
-    $i = $this->add($prefix . html::a(array(
-      'href' => $url_prefix . $url,
-      'target' => '_blank'
-      ), Q($url)) . $suffix);
+    if ($url) {
+      $suffix = $this->parse_url_brackets($url);
+      $i = $this->add($prefix . html::a(array(
+          'href' => $url_prefix . $url,
+          'target' => '_blank'
+        ), Q($url)) . $suffix);
+    }
 
     // Return valid link for recognized schemes, otherwise, return the unmodified string for unrecognized schemes.

tests/mailfunc.php

@@ -113 +113 @@
 
     $this->assertPattern('/<a href="mailto:nobody@roundcube.net" onclick="return rcmail.command\(\'compose\',\'nobody@roundcube.net\',this\)">nobody@roundcube.net<\/a>/', $html, "Mailto links with onclick");
-    $this->assertPattern('#<a href="http://www.apple.com/legal/privacy/" target="_blank">http://www.apple.com/legal/privacy/</a>#', $html, "Links with target=_blank");
+    $this->assertPattern('#<a href="http://www.apple.com/legal/privacy" target="_blank">http://www.apple.com/legal/privacy</a>#', $html, "Links with target=_blank");
     $this->assertPattern('#\\[<a href="http://example.com/\\?tx\\[a\\]=5" target="_blank">http://example.com/\\?tx\\[a\\]=5</a>\\]#', $html, "Links with square brackets");
   }

tests/src/plainbody.txt

@@ -31 +31 @@
 
 Privacy Policy
-http://www.apple.com/legal/privacy/
+http://www.apple.com/legal/privacy.
 
 My Info