Changeset 94e4be5 in github

Timestamp:

Sep 5, 2008 7:46:17 AM (5 years ago)

Author:

thomascube <thomas@…>

Branches:

master, HEAD, courier-fix, dev-browser-capabilities, pdo, release-0.6, release-0.7, release-0.8

Children:

c5e2d8b

Parents:

5f314da

Message:

Immediately save sort_col/sort_order in user prefs (#1485265)

Files:

• CHANGELOG (modified) (1 diff)
• program/include/rcmail.php (modified) (1 diff)
• program/steps/mail/list.inc (modified) (1 diff)

CHANGELOG

@@ -11 +11 @@
 - Allow application/pgp parts to be displayed (#1484753)
 - Correctly handle options in mailto-links (#1485228)
+- Immediately save sort_col/sort_order in user prefs (#1485265)
 
 2008/09/04 (alec)

program/include/rcmail.php

@@ -751 +751 @@
   public function kill_session()
   {
-    $user_prefs = $this->user->get_prefs();
-    
-    if ((isset($_SESSION['sort_col']) && $_SESSION['sort_col'] != $user_prefs['message_sort_col']) ||
-        (isset($_SESSION['sort_order']) && $_SESSION['sort_order'] != $user_prefs['message_sort_order'])) {
-      $this->user->save_prefs(array('message_sort_col' => $_SESSION['sort_col'], 'message_sort_order' => $_SESSION['sort_order']));
-    }
-
     $_SESSION = array('language' => $this->user->language, 'auth_time' => time(), 'temp' => true);
     setcookie('sessauth', '-del-', time() - 60);

program/steps/mail/list.inc

@@ -27 +27 @@
 
   // set session vars for sort (so next page and task switch know how to sort)
-  $_SESSION['sort_col'] = $sort_col;
-  $_SESSION['sort_order'] = $sort_order;
+  $save_arr = array();
+  $_SESSION['sort_col'] = $save_arr['message_sort_col'] = $sort_col;
+  $_SESSION['sort_order'] = $save_arr['message_sort_order'] = $sort_order;
+  
+  $RCMAIL->user->save_prefs($save_arr);
 }
 else