Changeset 8e3a603 in github

Timestamp:

Apr 13, 2010 3:24:09 AM (3 years ago)

Author:

thomascube <thomas@…>

Branches:

master, HEAD, courier-fix, dev-browser-capabilities, pdo, release-0.6, release-0.7, release-0.8

Children:

ed60fef

Parents:

6b01133

Message:

Assign newly created contacts to the active group (#1486626) and fix group selection display (#1486619)

Files:

• CHANGELOG (modified) (1 diff)
• program/include/rcube_contacts.php (modified) (2 diffs)
• program/js/app.js (modified) (3 diffs)
• program/steps/addressbook/edit.inc (modified) (1 diff)

CHANGELOG

@@ -2 +2 @@
 ===========================
 
+- Fix address book/group selection (#1486619)
+- Assign newly created contacts to the active group (#1486626)
 - Added option not to mark messages as read when viewed in preview pane (#1485012)
 - Allow plugins modify the Sent folder when composing (#1486548)

program/include/rcube_contacts.php

@@ -213 +213 @@
       {
         $ids = !is_array($value) ? explode(',', $value) : $value;
-        $add_where[] = $this->primary_key.' IN ('.join(',', $ids).')';
+        $add_where[] = 'c.' . $this->primary_key.' IN ('.join(',', $ids).')';
       }
       else if ($strict)
@@ -337 +337 @@
       $insert_id = $this->db->insert_id('contacts');
     }
+    
+    // also add the newly created contact to the active group
+    if ($insert_id && $this->group_id)
+      $this->add_to_group($this->group_id, $insert_id);
 
     return $insert_id;

program/js/app.js

@@ -526 +526 @@
 
           this.list_contacts(props);
-          this.enable_command('add', 'import', (this.env.address_sources && !this.env.address_sources[props].readonly));
+          this.enable_command('add', 'import', (this.env.address_sources && !this.env.address_sources[this.env.source].readonly));
           }
         break;
@@ -3444 +3444 @@
       page = this.env.current_page = 1;
 
-    this.select_folder(src, this.env.source);
-    this.select_folder(group, this.env.group, 'rcmliG');
+    this.select_folder((group ? 'G'+group : src), (this.env.group ? 'G'+this.env.group : this.env.source));
     
     this.env.source = src;
@@ -3517 +3516 @@
       {
       this.set_busy(true);
-      target.location.href = this.env.comm_path+'&_action='+action+'&_source='+urlencode(this.env.source)+'&_cid='+urlencode(cid) + add_url;
+      target.location.href = this.env.comm_path+'&_action='+action+'&_source='+urlencode(this.env.source)+'&_gid='+urlencode(this.env.group)+'&_cid='+urlencode(cid) + add_url;
       }
     return true;

program/steps/addressbook/edit.inc

@@ -89 +89 @@
   if (empty($EDIT_FORM)) {
     $hiddenfields = new html_hiddenfield(array('name' => '_source', 'value' => get_input_value('_source', RCUBE_INPUT_GPC)));
+    $hiddenfields->add(array('name' => '_gid', 'value' => $CONTACTS->group_id));
     
     if (($result = $CONTACTS->get_result()) && ($record = $result->first()))