Changeset 5914 in subversion

Timestamp:

Feb 26, 2012 12:02:16 PM (15 months ago)

Author:

alec

Message:

• Fixed identity delete button state, removed delete button in identity-edit form (for consistency)

Location:

trunk/roundcubemail

Files:

• program/js/app.js (modified) (5 diffs)
• skins/default/templates/identityedit.html (modified) (1 diff)
• skins/larry/templates/identityedit.html (modified) (1 diff)

trunk/roundcubemail/program/js/app.js

@@ -373 +373 @@
 
         if (this.env.action == 'identities') {
-          this.enable_command('add', 'delete', this.env.identities_level < 2);
+          this.enable_command('add', this.env.identities_level < 2);
         }
         else if (this.env.action == 'edit-identity' || this.env.action == 'add-identity') {
-          this.enable_command('add', this.env.identities_level < 2);
           this.enable_command('save', 'edit', 'toggle-editor', true);
-          if (this.is_framed() && this.env.identities_level < 2)
-            this.set_button('delete', 'act');  // activate button but delegate command to parent
-          else
-            this.enable_command('delete', this.env.identities_level < 2);
+          this.enable_command('delete', this.env.identities_level < 2);
 
           if (this.env.action == 'add-identity')
@@ -4808 +4804 @@
   {
     var id;
-    if (id = list.get_single_selection())
+    if (id = list.get_single_selection()) {
+      this.enable_command('delete', list.rowcount > 1 && this.env.identities_level < 2);
       this.load_identity(id, 'edit-identity');
+    }
   };
 
@@ -4815 +4813 @@
   this.load_identity = function(id, action)
   {
-    if (action=='edit-identity' && (!id || id==this.env.iid))
+    if (action == 'edit-identity' && (!id || id == this.env.iid))
       return false;
 
@@ -4826 +4824 @@
     }
 
-    if (action && (id || action=='add-identity')) {
+    if (action && (id || action == 'add-identity')) {
       this.set_busy(true);
       this.location_href(this.env.comm_path+'&_action='+action+'&_iid='+id+add_url, target);
@@ -4836 +4834 @@
   this.delete_identity = function(id)
   {
-    // exit if no mailbox specified or if selection is empty
+    // exit if no identity is specified or if selection is empty
     var selection = this.identity_list.get_selection();
     if (!(selection.length || this.env.iid))

trunk/roundcubemail/skins/default/templates/identityedit.html

@@ -24 +24 @@
 <div id="formfooter">
 <div class="footerleft">
-  <roundcube:button command="delete" type="input" class="button" label="delete" condition="env:action=='edit-identity'" style="margin-right:0.5em" />
   <roundcube:button command="save" type="input" class="button mainaction" label="save" />
 </div>

trunk/roundcubemail/skins/larry/templates/identityedit.html

@@ -16 +16 @@
 <div class="footerleft formbuttons">
         <roundcube:button command="save" type="input" class="button mainaction" label="save" />
-        <roundcube:button command="delete" type="input" class="button" label="delete" condition="env:action=='edit-identity' && config:identities_level:0<2" />
 </div>
 </div>