Changeset 5894 in subversion

Timestamp:

Feb 20, 2012 8:47:26 AM (16 months ago)

Author:

alec

Message:

• Make sure About tab is always the last tab (#1488257)

Location:

trunk/roundcubemail

Files:

• CHANGELOG (modified) (1 diff)
• skins/default/functions.js (modified) (1 diff)

trunk/roundcubemail/CHANGELOG

@@ -2 +2 @@
 ===========================
 
+- Make sure About tab is always the last tab (#1488257)
 - Fix issue with folder creation under INBOX. namespace (#1488349)
 - Added mailto: protocol handler registration link in User Preferences (#1486580)

trunk/roundcubemail/skins/default/functions.js

@@ -9 +9 @@
 function rcube_init_settings_tabs()
 {
-  var tab = '#settingstabdefault';
-  if (window.rcmail && rcmail.env.action)
-    tab = '#settingstab' + (rcmail.env.action=='preferences' ? 'default' : (rcmail.env.action.indexOf('identity')>0 ? 'identities' : rcmail.env.action.replace(/\./g, '')));
+  var el, cl, container = $('#tabsbar'),
+    last_tab = $('span:last', container),
+    tab = '#settingstabdefault',
+    action = window.rcmail && rcmail.env.action ? rcmail.env.action : null;
+
+  // move About tab to the end
+  if (last_tab && last_tab.attr('id') != 'settingstababout' && (el = $('#settingstababout'))) {
+    cl = el.clone(true);
+    el.remove();
+    last_tab.after(cl);
+  }
+
+  // get selected tab
+  if (action)
+    tab = '#settingstab' + (action == 'preferences' ? 'default' : (action.indexOf('identity')>0 ? 'identities' : action.replace(/\./g, '')));
 
   $(tab).addClass('tablink-selected');
-  $(tab + '> a').removeAttr('onclick').click(function() { return false; });
+  $(a, tab).removeAttr('onclick').click(function() { return false; });
 }