Changeset 5767 in subversion for branches/devel-framework/roundcubemail

Timestamp:

Jan 13, 2012 4:31:20 AM (17 months ago)

Author:

alec

Message:

• Improved performance by caching storage server's capabilities in session

File:

• branches/devel-framework/roundcubemail/program/include/rcube_imap.php (modified) (2 diffs)

branches/devel-framework/roundcubemail/program/include/rcube_imap.php

@@ -354 +354 @@
 
     /**
-     * Returns the IMAP server's capability
+     * Returns the IMAP server's capability.
      *
      * @param   string  $cap Capability name
@@ -362 +362 @@
     public function get_capability($cap)
     {
-        if (!$this->check_connection()) {
-            return false;
-        }
-
-        // @TODO: cache capabilities or store in session (?)
-        return $this->conn->getCapability(strtoupper($cap));
+        $cap      = strtoupper($cap);
+        $sess_key = "STORAGE_$cap";
+
+        if (!isset($_SESSION[$sess_key])) {
+            if (!$this->check_connection()) {
+                return false;
+            }
+
+            $_SESSION[$sess_key] = $this->conn->getCapability($cap);
+        }
+
+        return $_SESSION[$sess_key];
     }