Changeset 5561 in subversion for trunk/roundcubemail/program/include/rcube_result_index.php

Timestamp:

Dec 7, 2011 4:29:56 AM (18 months ago)

Author:

alec

Message:

• Cleanup + perf. improvement (substr_count() is really fast!)

File:

• trunk/roundcubemail/program/include/rcube_result_index.php (modified) (3 diffs)

trunk/roundcubemail/program/include/rcube_result_index.php

@@ -158 +158 @@
             $this->meta['length'] = 0;
         }
-        else
-            // @TODO: check performance substr_count() vs. explode()
+        else {
             $this->meta['count'] = 1 + substr_count($this->raw_data, self::SEPARATOR_ELEMENT);
+        }
 
         return $this->meta['count'];
@@ -186 +186 @@
     {
         if (!isset($this->meta['max'])) {
-            // @TODO: do it by parsing raw_data?
             $this->meta['max'] = (int) @max($this->get());
         }
@@ -202 +201 @@
     {
         if (!isset($this->meta['min'])) {
-            // @TODO: do it by parsing raw_data?
             $this->meta['min'] = (int) @min($this->get());
         }