Changeset 5476 in subversion

Timestamp:

Nov 23, 2011 1:53:58 PM (18 months ago)

Author:

thomasb

Message:

Improve clickjacking protection: bust frame or disable all form elements and abort UI initialization

Location:

trunk/roundcubemail/program

Files:

• include/rcube_template.php (modified) (1 diff)
• js/app.js (modified) (1 diff)

trunk/roundcubemail/program/include/rcube_template.php

@@ -72 +72 @@
         //$this->framed = $framed;
         $this->set_env('task', $task);
+        $this->set_env('x_frame_options', $this->app->config->get('x_frame_options', 'sameorigin'));
 
         // load the correct skin (in case user-defined)

trunk/roundcubemail/program/js/app.js

@@ -145 +145 @@
     for (n in this.gui_objects)
       this.gui_objects[n] = rcube_find_object(this.gui_objects[n]);
+
+    // clickjacking protection
+    if (this.env.x_frame_options) {
+      try {
+        // bust frame if not allowed
+        if (this.env.x_frame_options == 'deny' && top.location.href != self.location.href)
+          top.location.href = self.location.href;
+        else if (top.location.hostname != self.location.hostname)
+          throw 1;
+      } catch (e) {
+        // possible clickjacking attack: disable all form elements
+        $('form').each(function(){ ref.lock_form(this, true); });
+        this.display_message("Blocked: possible clickjacking attack!", 'error');
+        return;
+      }
+    }
 
     // init registered buttons