Changeset 5369 in subversion for trunk/roundcubemail/program/steps/mail/sendmail.inc

Timestamp:

Oct 26, 2011 9:53:30 AM (19 months ago)

Author:

alec

Message:

• Fix IDN address validation issue (#1488137)

File:

• trunk/roundcubemail/program/steps/mail/sendmail.inc (modified) (2 diffs)

trunk/roundcubemail/program/steps/mail/sendmail.inc

@@ -160 +160 @@
     // address in brackets without name (do nothing)
     if (preg_match('/^<'.$email_regexp.'>$/', $item)) {
-      $item = rcube_idn_to_ascii($item);
-      $result[] = $item;
+      $item = rcube_idn_to_ascii(trim($item, '<>'));
+      $result[] = '<' . $item . '>';
     // address without brackets and without name (add brackets)
     } else if (preg_match('/^'.$email_regexp.'$/', $item)) {
       $item = rcube_idn_to_ascii($item);
-      $result[] = '<'.$item.'>';
+      $result[] = '<' . $item . '>';
     // address with name (handle name)
-    } else if (preg_match('/'.$email_regexp.'>*$/', $item, $matches)) {
+    } else if (preg_match('/<*'.$email_regexp.'>*$/', $item, $matches)) {
       $address = $matches[0];
       $name = str_replace($address, '', $item);
@@ -175 +175 @@
             $name = '"'.addcslashes($name, '"').'"';
       }
-      $address = rcube_idn_to_ascii($address);
-      if (!preg_match('/^<'.$email_regexp.'>$/', $address))
-        $address = '<'.$address.'>';
+      $address = rcube_idn_to_ascii(trim($address, '<>'));
+      $address = '<' . $address . '>';
 
       $result[] = $name.' '.$address;