Changeset 5343 in subversion

Timestamp:

Oct 18, 2011 9:45:38 AM (20 months ago)

Author:

alec

Message:

• Code and small perf. improvements

File:

• trunk/roundcubemail/program/js/app.js (modified) (8 diffs)

trunk/roundcubemail/program/js/app.js

@@ -1679 +1679 @@
     });
 
-    var c, html, tree = expando = '',
+    var c, n, col, html, tree = '', expando = '',
       list = this.message_list,
       rows = list.rows,
-      tbody = this.gui_objects.messagelist.tBodies[0],
-      rowcount = tbody.rows.length,
-      even = rowcount%2,
       message = this.env.messages[uid],
       css_class = 'message'
@@ -1693 +1690 @@
         + (message.selected ? ' selected' : ''),
       // for performance use DOM instead of jQuery here
-      row = document.createElement('tr'),
-      col = document.createElement('td');
+      row = document.createElement('tr');
 
     row.id = 'rcmrow'+uid;
@@ -1721 +1717 @@
     // threads
     if (this.env.threading) {
-      // This assumes that div width is hardcoded to 15px,
-      var width = message.depth * 15;
       if (message.depth) {
+        // This assumes that div width is hardcoded to 15px,
+        tree += '<span id="rcmtab' + uid + '" class="branch" style="width:' + (message.depth * 15) + 'px;">&nbsp;&nbsp;</span>';
+
         if ((rows[message.parent_uid] && rows[message.parent_uid].expanded === false)
           || ((this.env.autoexpand_threads == 0 || this.env.autoexpand_threads == 2) &&
@@ -1738 +1735 @@
           message.expanded = true;
         }
-      }
-
-      if (width)
-        tree += '<span id="rcmtab' + uid + '" class="branch" style="width:' + width + 'px;">&nbsp;&nbsp;</span>';
-
-      if (message.has_children && !message.depth)
+
         expando = '<div id="rcmexpando' + uid + '" class="' + (message.expanded ? 'expanded' : 'collapsed') + '">&nbsp;&nbsp;</div>';
+      }
     }
 
@@ -1758 +1751 @@
 
     // add each submitted col
-    for (var n in this.env.coltypes) {
+    for (n in this.env.coltypes) {
       c = this.env.coltypes[n];
       col = document.createElement('td');
@@ -4116 +4109 @@
   this.add_contact_row = function(cid, cols, select)
   {
-    if (!this.gui_objects.contactslist || !this.gui_objects.contactslist.tBodies[0])
+    if (!this.gui_objects.contactslist)
       return false;
 
-    var c, tbody = this.gui_objects.contactslist.tBodies[0],
+    var c, list = this.contact_list,
       row = document.createElement('tr');
 
@@ -4125 +4118 @@
     row.className = 'contact';
 
-    if (this.contact_list.in_selection(cid))
+    if (list.in_selection(cid))
       row.className += ' selected';
 
@@ -4136 +4129 @@
     }
 
-    this.contact_list.insert_row(row);
-
-    this.enable_command('export', (this.contact_list.rowcount > 0));
+    list.insert_row(row);
+
+    this.enable_command('export', list.rowcount > 0);
   };