Changeset 5192 in subversion

Timestamp:

Sep 8, 2011 4:31:13 AM (21 months ago)

Author:

alec

Message:

• Fix new caching issue when broken/misleading object data was stored in database. The object must be cleaned up before storing in DB, because some code (out of rcube_message and rcube_imap classes) is changing objects data e.g. parts mimetype or body. Now it's become a problem because we're saving the object in cache at shutdown (after all modifications).
• Make stored message object smaller by removing some redundant data.

Location:

trunk/roundcubemail/program/include

Files:

• rcube_imap.php (modified) (1 diff)
• rcube_imap_cache.php (modified) (2 diffs)

trunk/roundcubemail/program/include/rcube_imap.php

@@ -2000 +2000 @@
 
         $struct = &$this->_structure_part($structure, 0, '', $headers);
-        $struct->headers = get_object_vars($headers);
 
         // don't trust given content-type
-        if (empty($struct->parts) && !empty($struct->headers['ctype'])) {
+        if (empty($struct->parts) && !empty($headers->ctype)) {
             $struct->mime_id = '1';
-            $struct->mimetype = strtolower($struct->headers['ctype']);
+            $struct->mimetype = strtolower($headers->ctype);
             list($struct->ctype_primary, $struct->ctype_secondary) = explode('/', $struct->mimetype);
         }

trunk/roundcubemail/program/include/rcube_imap_cache.php

@@ -889 +889 @@
         // Save current message from internal cache
         if ($message = $this->icache['message']) {
-            $object = $message['object'];
-            // remove body too big (>500kB)
-            if ($object->body && strlen($object->body) > 500 * 1024)
-                $object->body = null;
+            // clean up some object's data
+            $object = $this->message_object_prepare($message['object']);
 
             // calculate current md5 sum
@@ -905 +903 @@
     }
 
+
+    /**
+     * Prepares message object to be stored in database.
+     */
+    private function message_object_prepare($msg, $recursive = false)
+    {
+        // Remove body too big (>500kB)
+        if ($recursive || ($msg->body && strlen($msg->body) > 500 * 1024)) {
+            unset($msg->body);
+        }
+
+        // Fix mimetype which might be broken by some code when message is displayed
+        // Another solution would be to use object's copy in rcube_message class
+        // to prevent related issues, however I'm not sure which is better
+        if ($msg->mimetype) {
+            list($msg->ctype_primary, $msg->ctype_secondary) = explode('/', $msg->mimetype);
+        }
+
+        if (is_array($msg->structure->parts)) {
+            foreach ($msg->structure->parts as $idx => $part) {
+                $msg->structure->parts[$idx] = $this->message_object_prepare($part, true);
+            }
+        }
+
+        return $msg;
+    }
 }