Changeset 4b9efbb in github

Timestamp:

Aug 9, 2007 5:55:14 PM (6 years ago)

Author:

svncommit <devs@…>

Branches:

master, HEAD, courier-fix, dev-browser-capabilities, pdo, release-0.6, release-0.7, release-0.8

Children:

719a257

Parents:

6d969b4

Message:

Fixes interface lock-up issues and minor bugs (richs)

Files:

• .htaccess (modified) (1 diff)
• CHANGELOG (modified) (1 diff)
• INSTALL (modified) (1 diff)
• program/js/app.js (modified) (8 diffs)
• skins/default/mail.css (modified) (1 diff)
• skins/default/templates/compose.html (modified) (1 diff)

.htaccess

@@ -3 +3 @@
 php_flag        log_errors      On
 php_value       error_log       logs/errors
-php_value       upload_max_filesize     2M
+php_value       upload_max_filesize     5M
 
 <FilesMatch "(\.inc|\~)$">

CHANGELOG

@@ -1 +1 @@
 CHANGELOG RoundCube Webmail
 ---------------------------
+
+2007/07/09 (richs)
+----------
+- Fixed bug with buttons not dimming/enabling properly after switching folders
+- Fixed compose window becoming unresponsive after saving a draft (#1484487)
+- Re-enabled "Back" button in compose window now that bug #1484487 is fixed
+- Fixed unresponsive interface issue when downloading attachments (#1484496)
+- Lowered status message time from 5 to 3 seconds to improve responsiveness
+- Added note to INSTALL about .htaccess limiting upload_max_filesize
+- Raised .htaccess upload_max_filesize from 2M to 5M to differ from default php.ini
+- Increased "mailboxcontrols" mail.css width from 160 to 170px to fix non-english languages 
+- Fixed empty-message sending with TinyMCE plain-text mode, or if it's not installed
 
 2007/07/03 (thomasb)

INSTALL

@@ -104 +104 @@
 Details about the config paramaters can be found in the config files.
 
+You can also modify the default .htaccess file. This is necessary to
+increase the allowed size of file attachments, for example:
+        php_value       upload_max_filesize     2M
 
 UPGRADING

program/js/app.js

@@ -36 +36 @@
   // webmail client settings
   this.dblclick_time = 500;
-  this.message_time = 5000;
+  this.message_time = 3000;
   
   this.identifier_expr = new RegExp('[^0-9a-z\-_]', 'gi');
@@ -695 +695 @@
           }
 
-        this.goto_url('get', qstring+'&_download=1');
+        this.goto_url('get', qstring+'&_download=1', false);
         break;
         
@@ -1064 +1064 @@
       this.command('moveto', id);
       }
-  
+
+    // Hide message command buttons until a message is selected 
+    this.enable_command('reply', 'reply-all', 'forward', 'delete', 'print', false); 
     return false;
     };
@@ -1089 +1091 @@
 
     var selected = list.selection.length==1;
+
+    // Hide certain command buttons when Drafts folder is selected
     if (this.env.mailbox == this.env.drafts_mailbox)
       {
-      this.enable_command('show', selected);
-      this.enable_command('delete', 'moveto', list.selection.length>0 ? true : false);
+      this.enable_command('reply', 'reply-all', 'forward', false);
+      this.enable_command('show', 'delete', 'moveto', selected);
       }
     else
       {
-      this.enable_command('show', 'reply', 'reply-all', 'forward', 'print', selected);
-      this.enable_command('delete', 'moveto', list.selection.length>0 ? true : false);
+      this.enable_command('show', 'reply', 'reply-all', 'forward', 'print', 'delete', 'moveto', selected);
       }
 
@@ -1681 +1684 @@
 
     // check for empty body
-    if ((input_message.value=='')&&(tinyMCE.getContent()==''))
+    if ((input_message.value=='')&&(tinyMCE == null ? true : (tinyMCE.getContent()=='' || tinyMCE.getContent() == null)))
       {
       if (!confirm(this.get_label('nobodywarning')))
@@ -1712 +1715 @@
     if (this.env.draft_autosave)
       this.save_timer = self.setTimeout(function(){ ref.command("savedraft"); }, this.env.draft_autosave * 1000);
+
+    // Unlock interface now that saving is complete
+    this.busy = false;
     };
 
@@ -3188 +3194 @@
   /********************************************************/
 
-  this.redirect = function(url)
-    {
-    this.set_busy(true);
+  this.redirect = function(url, lock)
+    {
+    if (lock || lock == NULL)
+      this.set_busy(true);
+
     if (this.env.framed && window.parent)
       parent.location.href = url;
@@ -3199 +3207 @@
   this.goto_url = function(action, query, lock)
     {
-    if (lock)
-    this.set_busy(true);
-
     var querystring = query ? '&'+query : '';
-    this.redirect(this.env.comm_path+'&_action='+action+querystring);
+    this.redirect(this.env.comm_path+'&_action='+action+querystring, lock);
     };
 

skins/default/mail.css

@@ -339 +339 @@
   position: absolute;
   left: 20px;
-  width: 160px;
+  width: 170px;
   bottom: 20px;
   height: 16px;

skins/default/templates/compose.html

@@ -32 +32 @@
 
 <div id="messagetoolbar">
-<!--<roundcube:button command="list" image="/images/buttons/back_act.png" imageSel="/images/buttons/back_sel.png" imageAct="/images/buttons/back_act.png" width="32" height="32" title="backtolist" />-->
+<roundcube:button command="list" image="/images/buttons/back_act.png" imageSel="/images/buttons/back_sel.png" imageAct="/images/buttons/back_act.png" width="32" height="32" title="backtolist" />
 <roundcube:button command="send" imageSel="/images/buttons/send_sel.png" imageAct="/images/buttons/send_act.png" imagePas="/images/buttons/send_pas.png" width="32" height="32" title="sendmessage" />
 <roundcube:button command="spellcheck" imageSel="/images/buttons/spellcheck_sel.png" imageAct="/images/buttons/spellcheck_act.png" imagePas="/images/buttons/spellcheck_pas.png" width="32" height="32" title="checkspelling" />