Changeset 4575 in subversion

Timestamp:

Feb 27, 2011 8:30:34 AM (2 years ago)

Author:

thomasb

Message:

Improve vcard import: map more fields, support photo urls, better UTF-16 charset detection

Location:

trunk/roundcubemail

Files:

• program/include/rcube_vcard.php (modified) (6 diffs)
• program/steps/addressbook/func.inc (modified) (2 diffs)
• program/steps/addressbook/import.inc (modified) (1 diff)
• tests/src/utf-16_sample.vcf (added)
• tests/vcards.php (modified) (1 diff)

trunk/roundcubemail/program/include/rcube_vcard.php

@@ -41 +41 @@
     'email'    => 'EMAIL',
     'address'  => 'ADR',
+    'jobtitle' => 'TITLE',
     'gender'      => 'X-GENDER',
     'maidenname'  => 'X-MAIDENNAME',
@@ -166 +167 @@
             }
           }
+
+          // force subtype if none set
+          if (preg_match('/^(email|phone|address|website)/', $key) && !$subtype)
+            $subtype = 'other';
           
           if ($subtype)
@@ -278 +283 @@
         
       case 'photo':
-        $encoded = !preg_match('![^a-z0-9/=+-]!i', $value);
-        $this->raw['PHOTO'][0] = array(0 => $encoded ? $value : base64_encode($value), 'BASE64' => true);
+        if (strpos($value, 'http:') === 0) {
+            // TODO: fetch file from URL and save it locally?
+            $this->raw['PHOTO'][0] = array(0 => $value, 'URL' => true);
+        }
+        else {
+            $encoded = !preg_match('![^a-z0-9/=+-]!i', $value);
+            $this->raw['PHOTO'][0] = array(0 => $encoded ? $value : base64_encode($value), 'BASE64' => true);
+        }
         break;
         
@@ -423 +434 @@
     // Convert special types (like Skype) to normal type='skype' classes with this simple regex ;)
     $vcard = preg_replace(
-      '/item(\d+)\.(TEL|URL)([^:]*?):(.*?)item\1.X-ABLabel:(?:_\$!<)?([\w-() ]*)(?:>!\$_)?./s',
+      '/item(\d+)\.(TEL|EMAIL|URL)([^:]*?):(.*?)item\1.X-ABLabel:(?:_\$!<)?([\w-() ]*)(?:>!\$_)?./s',
       '\2;type=\5\3:\4',
+      $vcard);
+
+    // convert Apple X-ABRELATEDNAMES into X-* fields for better compatibility
+    $vcard = preg_replace_callback(
+      '/item(\d+)\.(X-ABRELATEDNAMES)([^:]*?):(.*?)item\1.X-ABLabel:(?:_\$!<)?([\w-() ]*)(?:>!\$_)?./s',
+      array('self', 'x_abrelatednames_callback'),
       $vcard);
 
@@ -440 +457 @@
 
     return $vcard;
+  }
+  
+  private static function x_abrelatednames_callback($matches)
+  {
+    return 'X-' . strtoupper($matches[5]) . $matches[3] . ':'. $matches[4];
   }
 
@@ -632 +654 @@
     if (substr($string, 0, 3) == "\xEF\xBB\xBF") return 'UTF-8';
 
+    // heuristics
+    if ($string[0] == "\0" && $string[1] == "\0" && $string[2] == "\0" && $string[3] != "\0") return 'UTF-32BE';
+    if ($string[0] != "\0" && $string[1] == "\0" && $string[2] == "\0" && $string[3] == "\0") return 'UTF-32LE';
+    if ($string[0] == "\0" && $string[1] != "\0" && $string[2] == "\0" && $string[3] != "\0") return 'UTF-16BE';
+    if ($string[0] != "\0" && $string[1] == "\0" && $string[2] != "\0" && $string[3] == "\0") return 'UTF-16LE';
+
     // use mb_detect_encoding()
     $encodings = array('UTF-8', 'ISO-8859-1', 'ISO-8859-2', 'ISO-8859-3',

trunk/roundcubemail/program/steps/addressbook/func.inc

@@ -366 +366 @@
                     if (!$coltypes[$col])
                         continue;
+                    
+                    // only string values are expected here
+                    if (is_array($record[$col]))
+                        $record[$col] = join(' ', $record[$col]);
 
                     if ($RCMAIL->action == 'show') {
@@ -564 +568 @@
         $RCMAIL->output->set_env('photo_placeholder', $photo_img);
         
-        if ($record['photo'])
+        if (strpos($record['photo'], 'http:') === 0)
+            $photo_img = $record['photo'];
+        else if ($record['photo'])
             $photo_img = $RCMAIL->url(array('_action' => 'photo', '_cid' => $record['ID'], '_source' => $_REQUEST['_source']));
         $img = html::img(array('src' => $photo_img, 'border' => 1, 'alt' => ''));

trunk/roundcubemail/program/steps/addressbook/import.inc

@@ -139 +139 @@
       $email = rcube_idn_to_utf8($email);
       
-      if (!$replace) {
+      if (!$replace && $email) {
         // compare e-mail address
         $existing = $CONTACTS->search('email', $email, false, false);

trunk/roundcubemail/tests/vcards.php

@@ -55 +55 @@
   }
   
+  function test_encodings()
+  {
+      $input = file_get_contents($this->_srcpath('utf-16_sample.vcf'));
+      
+      $vcards = rcube_vcard::import($input);
+      $this->assertEqual("njgean ĜdaMonté", $vcards[0]->displayname, "Decoded from UTF-16");
+  }
+  
 }