Changeset 4477 in subversion

Timestamp:

Feb 1, 2011 4:08:17 AM (2 years ago)

Author:

alec

Message:

• Unify typeof and undefined usage

Location:

trunk/roundcubemail/program/js

Files:

• common.js (modified) (5 diffs)
• googiespell.js (modified) (3 diffs)
• list.js (modified) (1 diff)

trunk/roundcubemail/program/js/common.js

@@ -168 +168 @@
 {
   e = e || window.event;
-  return e && (typeof e.button != 'undefined') ? e.button : (e && e.which ? e.which : 0);
+  return e && e.button !== undefined ? e.button : (e && e.which ? e.which : 0);
 },
 
@@ -319 +319 @@
 removeEventListener: function(evt, func, obj)
 {
-  if (typeof obj == 'undefined')
+  if (obj === undefined)
     obj = window;
 
@@ -336 +336 @@
 {
   var ret, h;
-  if (typeof e == 'undefined')
+  if (e === undefined)
     e = this;
-  else if (typeof e == 'object')
+  else if (typeof e === 'object')
     e.event = evt;
 
@@ -345 +345 @@
     for (var i=0; i < this._events[evt].length; i++) {
       if ((h = this._events[evt][i])) {
-        if (typeof h.func == 'function')
+        if (typeof h.func === 'function')
           ret = h.func.call ? h.func.call(h.obj, e) : h.func(e);
-        else if (typeof h.obj[h.func] == 'function')
+        else if (typeof h.obj[h.func] === 'function')
           ret = h.obj[h.func](e);
 
         // cancel event execution
-        if (typeof ret != 'undefined' && !ret)
+        if (ret !== undefined && !ret)
           break;
       }
@@ -514 +514 @@
 
   for (var key in obj) {
-    if (obj[key] && typeof obj[key] == 'object')
+    if (obj[key] && typeof obj[key] === 'object')
       out[key] = clone_object(obj[key]);
     else

trunk/roundcubemail/program/js/googiespell.js

@@ -92 +92 @@
 
 this.decorateTextarea = function(id) {
-    this.text_area = typeof(id) == 'string' ? document.getElementById(id) : id;
+    this.text_area = typeof id === 'string' ? document.getElementById(id) : id;
 
     if (this.text_area) {
@@ -121 +121 @@
 /////
 this.setSpellContainer = function(id) {
-    this.spell_container = typeof(id) == 'string' ? document.getElementById(id) : id;
+    this.spell_container = typeof id === 'string' ? document.getElementById(id) : id;
 };
 
@@ -932 +932 @@
 /////
 this.isDefined = function(o) {
-    return (o != 'undefined' && o != null)
+    return (o !== undefined && o !== null)
 };
 

trunk/roundcubemail/program/js/list.js

@@ -59 +59 @@
 
   // overwrite default paramaters
-  if (p && typeof(p) == 'object')
+  if (p && typeof p === 'object')
     for (var n in p)
       this[n] = p[n];