Changeset 4360 in subversion

Timestamp:

Dec 22, 2010 1:11:29 PM (2 years ago)

Author:

alec

Message:

• Fix handling (skipping) of unilateral untagged server responses (in THREAD/SORT/SEARCH commands)

File:

• trunk/roundcubemail/program/include/rcube_imap_generic.php (modified) (4 diffs)

trunk/roundcubemail/program/include/rcube_imap_generic.php

@@ -1151 +1151 @@
 
         if ($code == self::ERROR_OK) {
-            // remove prefix and \r\n from raw response
-            $response = str_replace("\r\n", '', substr($response, 7));
-            return preg_split('/\s+/', $response, -1, PREG_SPLIT_NO_EMPTY);
+            // remove prefix and unilateral untagged server responses
+            $response = substr($response, stripos($response, '* SORT') + 7);
+            if ($pos = strpos($response, '*')) {
+                $response = substr($response, 0, $pos);
+            }
+            return preg_split('/[\s\r\n]+/', $response, -1, PREG_SPLIT_NO_EMPTY);
         }
 
@@ -1890 +1893 @@
             $algorithm, $encoding, $criteria));
 
-        if ($code == self::ERROR_OK && preg_match('/^\* THREAD /i', $response)) {
-            // remove prefix and \r\n from raw response
-            $response    = str_replace("\r\n", '', substr($response, 9));
+        if ($code == self::ERROR_OK) {
+            // remove prefix...
+            $response = substr($response, stripos($response, '* THREAD') + 9);
+            // ...unilateral untagged server responses
+            if ($pos = strpos($response, '*')) {
+                $response = substr($response, 0, $pos);
+            }
+
+            $response    = str_replace("\r\n", '', $response);
             $depthmap    = array();
             $haschildren = array();
@@ -1950 +1959 @@
 
         if ($code == self::ERROR_OK) {
-            // remove prefix and \r\n from raw response
-            $response = substr($response, $esearch ? 10 : 9);
-            $response = str_replace("\r\n", '', $response);
+            // remove prefix...
+            $response = substr($response, stripos($response, 
+                $esearch ? '* ESEARCH' : '* SEARCH') + ($esearch ? 10 : 9));
+            // ...and unilateral untagged server responses
+            if ($pos = strpos($response, '*')) {
+                $response = rtrim(substr($response, 0, $pos));
+            }
 
             if ($esearch) {
@@ -1971 +1984 @@
             }
             else {
-                $response = preg_split('/\s+/', $response, -1, PREG_SPLIT_NO_EMPTY);
+                $response = preg_split('/[\s\r\n]+/', $response, -1, PREG_SPLIT_NO_EMPTY);
 
                 if (!empty($items)) {