Changeset 4077 in subversion

Timestamp:

Oct 12, 2010 4:56:46 AM (3 years ago)

Author:

alec

Message:

• Fix signature removal when replying in HTML to plain/text message

Location:

trunk/roundcubemail/program/steps/mail

Files:

• compose.inc (modified) (3 diffs)
• func.inc (modified) (1 diff)

trunk/roundcubemail/program/steps/mail/compose.inc

@@ -538 +538 @@
       }
       else {
-        $body = rcmail_plain_body($MESSAGE->first_text_part());
+        $body = $MESSAGE->first_text_part();
+        // try to remove the signature
+        if ($RCMAIL->config->get('strip_existing_sig', true))
+          $body = rcmail_remove_signature($body);
+        // add HTML formatting
+        $body = rcmail_plain_body($body);
         if ($body)
           $body = '<pre>' . $body . '</pre>';
@@ -711 +716 @@
 
     // try to remove the signature
-    if ($RCMAIL->config->get('strip_existing_sig', true)) {
-      $len = strlen($body);
-      while (($sp = strrpos($body, "-- \n", $sp ? -$len+$sp-1 : 0)) !== false) {
-        if ($sp == 0 || $body[$sp-1] == "\n") {
-          // do not touch blocks with more that X lines
-          if (substr_count($body, "\n", $sp) < $RCMAIL->config->get('sig_max_lines', 15)) {
-            $body = substr($body, 0, max(0, $sp-1));
-          }
-          break;
-        }
-      }
-    }
+    if ($RCMAIL->config->get('strip_existing_sig', true))
+      $body = rcmail_remove_signature($body);
 
     // soft-wrap and quote message text
@@ -836 +831 @@
   return $body;
 }
-  
-  
+
+
+function rcmail_remove_signature($body)
+{
+  global $RCMAIL;
+
+  $len = strlen($body);
+  $sig_max_lines = $RCMAIL->config->get('sig_max_lines', 15);
+
+  while (($sp = strrpos($body, "-- \n", $sp ? -$len+$sp-1 : 0)) !== false) {
+    if ($sp == 0 || $body[$sp-1] == "\n") {
+      // do not touch blocks with more that X lines
+      if (substr_count($body, "\n", $sp) < $sig_max_lines) {
+        $body = substr($body, 0, max(0, $sp-1));
+      }
+      break;
+    }
+  }
+
+  return $body;
+}
+
+
 function rcmail_write_compose_attachments(&$message, $bodyIsHtml)
 {

trunk/roundcubemail/program/steps/mail/func.inc

@@ -844 +844 @@
   $body = Q(join("\n", $a_lines), 'dummy', false);
 
-  // colorize signature
+  // colorize signature (up to <sig_max_lines> lines)
   $len = strlen($body);
+  $sig_max_lines = $RCMAIL->config->get('sig_max_lines', 15);
   while (($sp = strrpos($body, "-- \n", $sp ? -$len+$sp-1 : 0)) !== false) {
     if ($sp == 0 || $body[$sp-1] == "\n") {
       // do not touch blocks with more that X lines
-      if (substr_count($body, "\n", $sp) < $RCMAIL->config->get('sig_max_lines', 15))
+      if (substr_count($body, "\n", $sp) < $sig_max_lines)
         $body = substr($body, 0, max(0, $sp))
           .'<span class="sig">'.substr($body, $sp).'</span>';