Changeset 4030 in subversion for trunk/roundcubemail/program/include/rcmail.php

Timestamp:

Oct 4, 2010 3:03:00 AM (3 years ago)

Author:

alec

Message:

• Convert IDN to ASCII before using rcube_user::query()
• Always convert to lower case a username when it's an email address

File:

• trunk/roundcubemail/program/include/rcmail.php (modified) (2 diffs)

trunk/roundcubemail/program/include/rcmail.php

@@ -684 +684 @@
         $username = $virtuser;
 
+    // Here we need IDNA ASCII
+    // Only rcube_contacts class is using domain names in Unicode
+    $host = idn_to_ascii($host);
+    if (strpos($username, '@')) {
+      // lowercase username if it's an e-mail address (#1484473)
+      $username = mb_strtolower($username);
+      $username = idn_to_ascii($username);
+    }
+
     // user already registered -> overwrite username
     if ($user = rcube_user::query($username, $host))
@@ -691 +700 @@
       $this->imap_init();
 
-    // Here we need IDNA ASCII
-    // Only rcube_contacts class is using domain names in Unicode
-    $host = idn_to_ascii($host);
-    if (strpos($username, '@'))
-      $username = idn_to_ascii($username);
-
     // try IMAP login
     if (!($imap_login = $this->imap->connect($host, $username, $pass, $imap_port, $imap_ssl))) {
-      // lowercase username if it's an e-mail address (#1484473)
+      // try with lowercase
       $username_lc = mb_strtolower($username);
       if ($username_lc != $username && ($imap_login = $this->imap->connect($host, $username_lc, $pass, $imap_port, $imap_ssl)))