Changeset 3913 in subversion

Timestamp:

Aug 28, 2010 8:37:56 AM (3 years ago)

Author:

alec

Message:

• Fix JS error on IE when trying to send HTML message with enabled spellchecker (#1486940)

Location:

trunk/roundcubemail

Files:

• CHANGELOG (modified) (1 diff)
• program/js/app.js (modified) (3 diffs)

trunk/roundcubemail/CHANGELOG

@@ -13 +13 @@
 - Fix TinyMCE uses zh_CN when zh_TW locale is set (#1486929)
 - Fix TinyMCE buttons are hidden in Opera (#1486922)
+- Fix JS error on IE when trying to send HTML message with enabled spellchecker (#1486940)
 
 RELEASE 0.4

trunk/roundcubemail/program/js/app.js

@@ -2753 +2753 @@
   {
     // check input fields
-    var input_to = $("[name='_to']");
-    var input_cc = $("[name='_cc']");
-    var input_bcc = $("[name='_bcc']");
-    var input_from = $("[name='_from']");
-    var input_subject = $("[name='_subject']");
-    var input_message = $("[name='_message']");
+    var ed, input_to = $("[name='_to']"),
+      input_cc = $("[name='_cc']"),
+      input_bcc = $("[name='_bcc']"),
+      input_from = $("[name='_from']"),
+      input_subject = $("[name='_subject']"),
+      input_message = $("[name='_message']");
 
     // check sender (if have no identities)
@@ -2796 +2796 @@
     }
 
+    // Apply spellcheck changes if spell checker is active
+    this.stop_spellchecking();
+
+    if (window.tinyMCE)
+      ed = tinyMCE.get(this.env.composebody);
+
     // check for empty body
-    if ((!window.tinyMCE || !tinyMCE.get(this.env.composebody))
-        && input_message.val() == '' && !confirm(this.get_label('nobodywarning'))) {
+    if (!ed && input_message.val() == '' && !confirm(this.get_label('nobodywarning'))) {
       input_message.focus();
       return false;
     }
-    else if (window.tinyMCE && tinyMCE.get(this.env.composebody)
-        && !tinyMCE.get(this.env.composebody).getContent()
-        && !confirm(this.get_label('nobodywarning'))) {
-      tinyMCE.get(this.env.composebody).focus();
-      return false;
-    }
-
-    // Apply spellcheck changes if spell checker is active
-    this.stop_spellchecking();
-
-    // move body from html editor to textarea (just to be sure, #1485860)
-    if (window.tinyMCE && tinyMCE.get(this.env.composebody))
+    else if (ed) {
+      if (!ed.getContent() && !confirm(this.get_label('nobodywarning'))) {
+        ed.focus();
+        return false;
+      }
+      // move body from html editor to textarea (just to be sure, #1485860)
       tinyMCE.triggerSave();
+    }
 
     return true;
@@ -2846 +2846 @@
   this.stop_spellchecking = function()
   {
-    if (this.env.spellcheck && !this.spellcheck_ready) {
-      $(this.env.spellcheck.spell_span).trigger('click');
+    var ed;
+    if (window.tinyMCE && (ed = tinyMCE.get(this.env.composebody))) {
+      ed.execCommand('mceSpellCheck');
+    }
+    else if ((ed = this.env.spellcheck) && !this.spellcheck_ready) {
+      $(ed.spell_span).trigger('click');
       this.set_spellcheck_state('ready');
     }