Changeset 3621 in subversion

Timestamp:

May 15, 2010 10:49:10 AM (3 years ago)

Author:

alec

Message:

• improve performance of threads expanding/collapsing (significant on IE)

File:

• trunk/roundcubemail/program/js/list.js (modified) (3 diffs)

trunk/roundcubemail/program/js/list.js

@@ -487 +487 @@
         if (r.has_children) {
           r.expanded = false;
-          this.update_expando(r.uid);
+          if (!r.depth || !this.multiexpand)
+            this.update_expando(r.uid, false);
           this.triggerEvent('expandcollapse', { uid:r.uid, expanded:r.expanded });
         }
@@ -526 +527 @@
         if (r.has_children) {
           r.expanded = true;
-          this.update_expando(r.uid, true);
+          // in multiexpand mode only root has expando icon
+          // so we don't need to set it for children, this
+          // improves performance because getElementById()
+          // is relatively slow on IE 
+          if (!r.depth || !this.multiexpand)
+            this.update_expando(r.uid, true);
           this.triggerEvent('expandcollapse', { uid:r.uid, expanded:r.expanded });
         }
@@ -1044 +1050 @@
       this.collapse(selected_row);
 
-  var expando = document.getElementById('rcmexpando' + selected_row.uid);
-  if (expando)
-    expando.className = selected_row.expanded?'expanded':'collapsed';
+  this.update_expando(selected_row.uid, selected_row.expanded);
 
   return false;