Changeset 3268 in subversion

Timestamp:

Feb 13, 2010 12:33:25 PM (3 years ago)

Author:

alec

Message:

• Fix imap_init hook broken in r3258 (#1486493)

Location:

trunk/roundcubemail

Files:

• index.php (modified) (1 diff)
• program/include/rcmail.php (modified) (4 diffs)
• program/include/rcube_plugin_api.php (modified) (1 diff)
• program/steps/mail/func.inc (modified) (2 diffs)

trunk/roundcubemail/index.php

@@ -31 +31 @@
 require_once 'program/include/iniset.php';
 
-// init application and start session with requested task
+// init application, start session, init output class, etc.
 $RCMAIL = rcmail::get_instance();
-
-// init output class
-$OUTPUT = !empty($_REQUEST['_remote']) ? $RCMAIL->init_json() : $RCMAIL->load_gui(!empty($_REQUEST['_framed']));
-
-// init plugin API
-$RCMAIL->plugins->init();
 
 // turn on output buffering

trunk/roundcubemail/program/include/rcmail.php

@@ -131 +131 @@
     $_SESSION['task'] = $this->task;
 
-    // create IMAP object
-    if ($this->task == 'login')
-      $this->imap_init();
-      
+    // init output class
+    if (!empty($_REQUEST['_remote']))
+      $GLOBALS['OUTPUT'] = $this->init_json();
+    else
+      $GLOBALS['OUTPUT'] = $this->load_gui(!empty($_REQUEST['_framed']));
+
     // create plugin API and load plugins
     $this->plugins = rcube_plugin_api::get_instance();
+
+    // init plugins
+    $this->plugins->init();
   }
   
@@ -396 +401 @@
     // set global object for backward compatibility
     $GLOBALS['IMAP'] = $this->imap;
-    
+
+    $hook = $this->plugins->exec_hook('imap_init', array('fetch_headers' => $this->imap->fetch_add_headers));
+    if ($hook['fetch_headers'])
+      $this->imap->fetch_add_headers = $hook['fetch_headers'];
+                                        
     if ($connect)
       $this->imap_connect();
@@ -410 +419 @@
   {
     $conn = false;
+
+    if (!$this->imap)
+      $this->imap_init();
     
     if ($_SESSION['imap_host'] && !$this->imap->conn) {
@@ -494 +506 @@
     if ($user = rcube_user::query($username, $host))
       $username = $user->data['username'];
+
+    if (!$this->imap)
+      $this->imap_init();
 
     // exit if IMAP login failed

trunk/roundcubemail/program/include/rcube_plugin_api.php

@@ -151 +151 @@
     
     // maybe also register a shudown function which triggers shutdown functions of all plugin objects
-    
-    
-    // call imap_init right now
-    // (should actually be done in rcmail::imap_init() but plugins are not initialized then)
-    if ($rcmail->imap) {
-      $hook = $this->exec_hook('imap_init', array('fetch_headers' => $rcmail->imap->fetch_add_headers));
-      if ($hook['fetch_headers'])
-        $rcmail->imap->fetch_add_headers = $hook['fetch_headers'];
-    }
   }
   

trunk/roundcubemail/program/steps/mail/func.inc

@@ -25 +25 @@
 $NOIMAP_ACTIONS = array('spell', 'addcontact', 'autocomplete', 'upload', 'display-attachment', 'remove-attachment');
 
-// Init IMAP object
-$RCMAIL->imap_init();
-
 // log in to imap server
 if (!in_array($RCMAIL->action, $NOIMAP_ACTIONS) && !$RCMAIL->imap_connect()) {
@@ -43 +40 @@
 if ($mbox = get_input_value('_mbox', RCUBE_INPUT_GPC))
   $IMAP->set_mailbox(($_SESSION['mbox'] = $mbox));
-else
+else if ($IMAP)
   $_SESSION['mbox'] = $IMAP->get_mailbox_name();