Changeset 2e6825b in github

Timestamp:

Sep 5, 2008 5:55:07 AM (5 years ago)

Author:

thomascube <thomas@…>

Branches:

master, HEAD, courier-fix, dev-browser-capabilities, pdo, release-0.6, release-0.7, release-0.8

Children:

be5f03b

Parents:

a6d7a9f

Message:

Applied mime_decode patch by David Lublink

Files:

• CHANGELOG (modified) (1 diff)
• program/include/rcube_imap.php (modified) (1 diff)

CHANGELOG

@@ -6 +6 @@
 - Enable export of address book contacts as vCard
 - Respect Content-Location headers in multipart/related messages according to RFC2110 (#1484946)
+- Applied mime_decode patch by David Lublink
 
 2008/09/04 (alec)

program/include/rcube_imap.php

@@ -2417 +2417 @@
   function decode_mime_string($input, $fallback=null)
     {
+    // Initialize variable
     $out = '';
 
-    $pos = strpos($input, '=?');
-    if ($pos !== false)
-      {
-      // rfc: all line breaks or other characters not found 
-      // in the Base64 Alphabet must be ignored by decoding software
-      // delete all blanks between MIME-lines, differently we can 
-      // receive unnecessary blanks and broken utf-8 symbols
-      $input = preg_replace("/\?=\s+=\?/", '?==?', $input);
-
-      $out = substr($input, 0, $pos);
-  
-      $end_cs_pos = strpos($input, "?", $pos+2);
-      $end_en_pos = strpos($input, "?", $end_cs_pos+1);
-      $end_pos = strpos($input, "?=", $end_en_pos+1);
-  
-      $encstr = substr($input, $pos+2, ($end_pos-$pos-2));
-      $rest = substr($input, $end_pos+2);
-
-      $out .= rcube_imap::_decode_mime_string_part($encstr);
-      $out .= rcube_imap::decode_mime_string($rest, $fallback);
-
+    // Iterate instead of recursing, this way if there are too many values we don't have stack overflows
+    // rfc: all line breaks or other characters not found 
+    // in the Base64 Alphabet must be ignored by decoding software
+    // delete all blanks between MIME-lines, differently we can 
+    // receive unnecessary blanks and broken utf-8 symbols
+    $input = preg_replace("/\?=\s+=\?/", '?==?', $input);
+
+    // Check if there is stuff to decode
+    if (strpos($input, '=?') !== false) {
+      // Loop through the string to decode all occurences of =? ?= into the variable $out 
+      while(($pos = strpos($input, '=?')) !== false) {
+        // Append everything that is before the text to be decoded
+        $out .= substr($input, 0, $pos);
+
+        // Get the location of the text to decode
+        $end_cs_pos = strpos($input, "?", $pos+2);
+        $end_en_pos = strpos($input, "?", $end_cs_pos+1);
+        $end_pos = strpos($input, "?=", $end_en_pos+1);
+
+        // Extract the encoded string
+        $encstr = substr($input, $pos+2, ($end_pos-$pos-2));
+        // Extract the remaining string
+        $input = substr($input, $end_pos+2);
+
+        // Decode the string fragement
+        $out .= rcube_imap::_decode_mime_string_part($encstr);
+      }
+
+      // Deocde the rest (if any)
+      if (strlen($input) != 0)
+         $out .= rcube_imap::decode_mime_string($input, $fallback);
+
+       // return the results
       return $out;
-      }
+    }
 
     // no encoding information, use fallback