Changeset 2a5d02a in github

Timestamp:

Jul 21, 2009 12:13:42 PM (4 years ago)

Author:

thomascube <thomas@…>

Branches:

master, HEAD, courier-fix, dev-browser-capabilities, pdo, release-0.6, release-0.7, release-0.8

Children:

a0c4cbe

Parents:

5499336

Message:

Also protect GET request from CSRF

Files:

• CHANGELOG (modified) (1 diff)
• program/js/app.js (modified) (1 diff)
• program/steps/settings/delete_identity.inc (modified) (2 diffs)

CHANGELOG

@@ -4 +4 @@
 - Fix import of vCard entries with params (#1485453)
 - Fix HTML messages output with empty block elements (#1485974)
+- Use request tokens to protect POST requests from CSFR
 - Added hook when killing a session
 - Added hook to write_log function (#1485971)

program/js/app.js

@@ -2970 +2970 @@
       id = this.env.iid ? this.env.iid : selection[0];
 
-    // if (this.env.framed && id)
-    this.goto_url('delete-identity', '_iid='+id, true);
+    // append token to request
+    this.goto_url('delete-identity', '_iid='+id+'&_token='+this.env.request_token, true);
+    
     return true;
     };

program/steps/settings/delete_identity.inc

@@ -6 +6 @@
  |                                                                       |
  | This file is part of the RoundCube Webmail client                     |
- | Copyright (C) 2005-2007, RoundCube Dev. - Switzerland                 |
+ | Copyright (C) 2005-2009, RoundCube Dev. - Switzerland                 |
  | Licensed under the GNU GPL                                            |
  |                                                                       |
@@ -20 +20 @@
 */
 
-if (($ids = get_input_value('_iid', RCUBE_INPUT_GET)) && preg_match('/^[0-9]+(,[0-9]+)*$/', $ids))
+$iid = get_input_value('_iid', RCUBE_INPUT_GPC);
+
+// check request token
+if (!$OUTPUT->ajax_call && !$RCMAIL->check_request(RCUBE_INPUT_GPC)) {
+  $OUTPUT->show_message('invalidrequest', 'error');
+  rcmail_overwrite_action('identities');
+  return;
+}
+
+if ($iid && preg_match('/^[0-9]+(,[0-9]+)*$/', $iid))
 {
-  $plugin = $RCMAIL->plugins->exec_hook('delete_identity', array('id' => $ids));
+  $plugin = $RCMAIL->plugins->exec_hook('delete_identity', array('id' => $iid));
   
-  if (!$plugin['abort'] && $USER->delete_identity($ids)) {
+  if (!$plugin['abort'] && $USER->delete_identity($iid)) {
     $OUTPUT->show_message('deletedsuccessfully', 'confirmation', null, false);
   }