Changeset 2607 in subversion

Timestamp:

Jun 4, 2009 4:01:31 PM (4 years ago)

Author:

alec

Message:

• fix drag_move performance

File:

• trunk/roundcubemail/program/js/app.js (modified) (2 diffs)

trunk/roundcubemail/program/js/app.js

@@ -1263 +1263 @@
       for (var k in model) {
         if (li = this.get_folder_li(k)) {
-          pos = $(li.firstChild).offset();
-          // only visible folders
-          if (height = li.firstChild.offsetHeight)
-            this.env.folder_coords[k] = { x1:pos.left, y1:pos.top, x2:pos.left + li.firstChild.offsetWidth, y2:pos.top + height };
+          // only visible folders
+          if (height = li.firstChild.offsetHeight) {
+            pos = $(li.firstChild).offset();
+            this.env.folder_coords[k] = { x1:pos.left, y1:pos.top, x2:pos.left + li.firstChild.offsetWidth, y2:pos.top + height, on:0 };
+          }
         }
       }
@@ -1309 +1310 @@
         return;
       }
-
+    
+      var last = this.env.last_folder_target;
       // over the folders
       for (var k in this.env.folder_coords) {
         pos = this.env.folder_coords[k];
-        if (this.check_droptarget(k) && ((mouse.x >= pos.x1) && (mouse.x < pos.x2) 
-            && (mouse.y >= pos.y1) && (mouse.y < pos.y2))) {
+        if ((mouse.x >= pos.x1) && (mouse.x < pos.x2) 
+            && (mouse.y >= pos.y1) && (mouse.y < pos.y2)
+            && this.check_droptarget(k)) {
+          if (k == last)
+            continue; 
           $(this.get_folder_li(k)).addClass('droptarget');
           this.env.last_folder_target = k;
-        }
-        else {
+          this.env.folder_coords[k].on = 1;
+        }
+        else if (pos.on){
+          if (k == last)
+            this.env.last_folder_target = null;
+          this.env.folder_coords[k].on = 0;
           $(this.get_folder_li(k)).removeClass('droptarget');
-          if (k == this.env.last_folder_target)
-            this.env.last_folder_target = null;
-        }
+        }
       }
     }
   };
-  
+
   this.collapse_folder = function(id)
     {