Changeset 25d8ba6 in github

Timestamp:

Jun 30, 2006 6:02:28 PM (7 years ago)

Author:

svncommit <devs@…>

Branches:

master, HEAD, courier-fix, dev-browser-capabilities, pdo, release-0.6, release-0.7, release-0.8

Children:

5084427

Parents:

a894ba5

Message:

Misc bug and compatibility fixes

Files:

• CHANGELOG (modified) (1 diff)
• INSTALL (modified) (1 diff)
• program/include/rcube_imap.inc (modified) (1 diff)
• program/js/app.js (modified) (7 diffs)
• program/lib/imap.inc (modified) (1 diff)
• program/localization/fr/labels.inc (modified) (1 diff)
• program/steps/mail/check_recent.inc (modified) (1 diff)
• program/steps/mail/func.inc (modified) (1 diff)

CHANGELOG

@@ -1 +1 @@
 CHANGELOG RoundCube Webmail
 ---------------------------
+
+2006/06/30 (richs)
+----------
+- Fixed empty INBOX compatibility bug (Patch #1443200)
+- Temporarily fixed French "compact" localization (Patch #1483862)
+- Fixed "Select All" not working with Delete interface button (Bug #1332434)
+- Fixed messsage list column compatibility with Konqueror (Bug #1395711)
+- Fixed "unread count" in window title when count changed (Bug #1483812)
+- Fixed DB error when deleting from message table (Patch #1483835)
 
 2006/06/29 (richs)

INSTALL

@@ -10 +10 @@
    - error_reporting E_ALL & ~E_NOTICE (or lower)
    - file_uploads on (for attachment upload features)
+   - memory_limit (increase as suitable to support large attachments)
 * A MySQL or PostgreSQL database engine or the SQLite extension for PHP
 * A database with permission to create tables

program/include/rcube_imap.inc

@@ -1061 +1061 @@
       foreach ($a_uids as $uid)
         {
-        $index = array_search($uid, $a_cache_index);
-        $start_index = min($index, $start_index);
+        if(($index = array_search($uid, $a_cache_index)) !== FALSE)
+          $start_index = min($index, $start_index);
         }
 

program/js/app.js

@@ -1453 +1453 @@
     for (var n in this.list_rows) {
       if (!filter || this.list_rows[n][filter]==true)
+        this.last_selected = n;
         this.highlight_row(n, true);
     }
@@ -3011 +3012 @@
     };
 
+  // for reordering column array, Konqueror workaround
+  this.set_message_coltypes = function(coltypes) 
+  { 
+  this.coltypes = coltypes; 
+  }
 
   // create a table row in the message list
@@ -3043 +3049 @@
 
     // add each submitted col
-    for (var c in cols)
-      {
+    for (var n = 0; n < this.coltypes.length; n++) 
+      { 
+      var c = this.coltypes[n];
       col = document.createElement('TD');
       col.className = String(c).toLowerCase();
@@ -3088 +3095 @@
     if (!this.gui_objects.mailboxlist)
       return false;
-      
+
+    if (mbox==this.env.mailbox)
+      set_title = true;
+
     var item, reg, text_obj;
     mbox = String(mbox).toLowerCase().replace(this.mbox_expression, '');
@@ -3105 +3115 @@
       else
         text_obj.innerHTML = text_obj.innerHTML.replace(reg, '');
-          
+
       // set the right classes
       this.set_classname(item, 'unread', count>0 ? true : false);
@@ -3112 +3122 @@
     // set unread count to window title
     reg = /^\([0-9]+\)\s+/i;
-    if (set_title && count && document.title)   
+    if (set_title && document.title)
       {
       var doc_title = String(document.title);
@@ -3122 +3132 @@
       else
         document.title = doc_title.replace(reg, '');
-      }
-    // remove unread count from window title
-    else if (document.title)
-      {
-      document.title = document.title.replace(reg, '');
       }
     };

program/lib/imap.inc

@@ -676 +676 @@
         $index_field = strtoupper($index_field);
         
-        if (empty($message_set)) return array();
+        if ((empty($message_set)) || ($message_set == "1:0")) return array();
         
         //$fields_a["DATE"] = ($IMAP_USE_INTERNAL_DATE?6:1);

program/localization/fr/labels.inc

@@ -109 +109 @@
 $labels['unread'] = 'Non lus';
 
-$labels['compact'] = 'Compresser';
+//$labels['compact'] = 'Compresser';
 $labels['empty'] = 'Vider';
 $labels['purge'] = 'Purger';

program/steps/mail/check_recent.inc

@@ -33 +33 @@
       $unread_count = $IMAP->messagecount(NULL, 'UNSEEN', TRUE);
 
-      $commands .= sprintf("this.set_unread_count('%s', %d, true);\n", addslashes($mbox_name), $unread_count);
+      $commands .= sprintf("this.set_unread_count('%s', %d);\n", addslashes($mbox_name), $unread_count);
       $commands .= sprintf("this.set_env('messagecount', %d);\n", $count);
       $commands .= sprintf("this.set_rowcount('%s');\n", rcmail_get_messagecount_text());

program/steps/mail/func.inc

@@ -501 +501 @@
     $a_show_cols[$f] = 'to';
 
+  $commands .= sprintf("this.set_message_coltypes(%s);\n", array2js($a_show_cols)); 
+
   // loop through message headers
   for ($n=0; $a_headers[$n]; $n++)