Changeset 1589 in subversion


Ignore:
Timestamp:
07/14/08 13:56:22 (6 years ago)
Author:
thomasb
Message:

Re-enable autocomplete attribute for login form (#1485211)

Location:
trunk/roundcubemail
Files:
4 edited

Legend:

Unmodified
Added
Removed
  • trunk/roundcubemail/CHANGELOG

    r1580 r1589  
    11CHANGELOG RoundCube Webmail 
    22--------------------------- 
     3 
     42008/07/14 (thomasb) 
     5---------- 
     6- Re-enable autocomplete attribute for login form (#1485211) 
    37 
    482008/06/30 (alec) 
  • trunk/roundcubemail/program/include/html.php

    r1538 r1589  
    3030    protected $tagname; 
    3131    protected $attrib = array(); 
    32     protected $allowed; 
     32    protected $allowed = array(); 
    3333    protected $content; 
    3434 
     
    5656    public function show() 
    5757    { 
    58         return self::tag($this->tagname, $this->attrib, $this->content, $this->allowed); 
     58        return self::tag($this->tagname, $this->attrib, $this->content, array_merge(self::$common_attrib, $this->allowed)); 
    5959    } 
    6060 
     
    249249    protected $tagname = 'input'; 
    250250    protected $type = 'text'; 
     251    protected $allowed = array('type','name','value','size','tabindex','autocomplete','checked'); 
    251252 
    252253    public function __construct($attrib = array()) 
     
    416417{ 
    417418    protected $tagname = 'textarea'; 
    418     protected $allowed_attrib = array('name','rows','cols','wrap','tabindex'); 
     419    protected $allowed = array('name','rows','cols','wrap','tabindex'); 
    419420 
    420421    /** 
     
    446447        } 
    447448 
    448         return self::tag($this->tagname, $this->attrib, $value, array_merge(self::$common_attrib, $this->allowed_attrib)); 
     449        return self::tag($this->tagname, $this->attrib, $value, array_merge(self::$common_attrib, $this->allowed)); 
    449450    } 
    450451} 
  • trunk/roundcubemail/program/include/rcube_template.php

    r1562 r1589  
    909909        $_SESSION['temp'] = true; 
    910910 
    911         $input_user   = new html_inputfield(array('name' => '_user', 'id' => 'rcmloginuser', 'size' => 30, 'autocomplete' => 'off')); 
    912         $input_pass   = new html_passwordfield(array('name' => '_pass', 'id' => 'rcmloginpwd', 'size' => 30)); 
     911        $input_user   = new html_inputfield(array('name' => '_user', 'id' => 'rcmloginuser', 'size' => 30) + $attrib); 
     912        $input_pass   = new html_passwordfield(array('name' => '_pass', 'id' => 'rcmloginpwd', 'size' => 30) + $attrib); 
    913913        $input_action = new html_hiddenfield(array('name' => '_action', 'value' => 'login')); 
    914914        $input_host   = null; 
     
    927927            } 
    928928        } 
    929         else if (!strlen($default_host)) { 
     929        else if (empty($default_host)) { 
    930930            $input_host = new html_inputfield(array('name' => '_host', 'id' => 'rcmloginhost', 'size' => 30)); 
    931931        } 
     
    938938 
    939939        $table->add('title', html::label('rcmloginuser', Q(rcube_label('username')))); 
    940         $table->add(null, $input_user->show(get_input_value('_user', RCUVE_INPUT_POST))); 
     940        $table->add(null, $input_user->show(get_input_value('_user', RCUBE_INPUT_POST))); 
    941941 
    942942        $table->add('title', html::label('rcmloginpwd', Q(rcube_label('password')))); 
     
    946946        if (is_object($input_host)) { 
    947947            $table->add('title', html::label('rcmloginhost', Q(rcube_label('server')))); 
    948             $table->add(null, $input_host->show(get_input_value('_host', RCUVE_INPUT_POST))); 
     948            $table->add(null, $input_host->show(get_input_value('_host', RCUBE_INPUT_POST))); 
    949949        } 
    950950 
  • trunk/roundcubemail/skins/default/templates/login.html

    r1200 r1589  
    3838 
    3939<form name="form" action="./" method="post"> 
    40 <roundcube:object name="loginform" form="form" /> 
     40<roundcube:object name="loginform" form="form" autocomplete="off" /> 
    4141 
    4242<p style="text-align:center;"><input type="submit" class="button" value="<roundcube:label name='login' />" /></p> 
Note: See TracChangeset for help on using the changeset viewer.