Changeset 1431 in subversion

Timestamp:

May 27, 2008 4:08:30 AM (5 years ago)

Author:

thomasb

Message:

iil_C_FetchHeaders does not always return the headers in the correct order -> sort them manually; improved rcube_header_sorter performance

File:

• trunk/roundcubemail/program/include/rcube_imap.php (modified) (4 diffs)

trunk/roundcubemail/program/include/rcube_imap.php

@@ -576 +576 @@
       // retrieve headers from IMAP
       if ($this->get_capability('sort') && ($msg_index = iil_C_Sort($this->conn, $mailbox, $this->sort_field, $this->skip_deleted ? 'UNDELETED' : '')))
-        {        
-        $mymsgidx = array_slice ($msg_index, $begin, $end-$begin, true);
+        {
+        $mymsgidx = array_slice ($msg_index, $begin, $end-$begin);
         $msgs = join(",", $mymsgidx);
-        $headers_sorted = true;
         }
       else
@@ -2790 +2789 @@
    function set_sequence_numbers($seqnums)
    {
-      $this->sequence_numbers = $seqnums;
+      $this->sequence_numbers = array_flip($seqnums);
    }
  
@@ -2811 +2810 @@
  
    /**
-    * Get the position of a message sequence number in my sequence_numbers array
-    *
-    * @param int Message sequence number contained in sequence_numbers
-    * @return int Position, -1 if not found
-    */
-   function position_of($seqnum)
-   {
-      $pos = array_search($seqnum, $this->sequence_numbers);
-      if ($pos === false) return -1;
-      return $pos;
-   }
- 
-   /**
     * Sort method called by uasort()
     */
@@ -2833 +2819 @@
       
       // then find each sequence number in my ordered list
-      $posa = $this->position_of($seqa);
-      $posb = $this->position_of($seqb);
+      $posa = isset($this->sequence_numbers[$seqa]) ? intval($this->sequence_numbers[$seqa]) : -1;
+      $posb = isset($this->sequence_numbers[$seqb]) ? intval($this->sequence_numbers[$seqb]) : -1;
       
       // return the relative position as the comparison value
-      $ret = $posa - $posb;
-      return $ret;
+      return $posa - $posb;
    }
 }