Changeset 14259ce in github

Timestamp:

May 25, 2010 4:42:39 AM (3 years ago)

Author:

alecpl <alec@…>

Branches:

master, HEAD, courier-fix, dev-browser-capabilities, pdo, release-0.6, release-0.7, release-0.8

Children:

1a4fa6f

Parents:

3831efb

Message:

• fixed parse error
• support arguments of type object in enable_command()
• simplify setting of state of message commands

File:

• program/js/app.js (modified) (7 diffs)

program/js/app.js

@@ -200 +200 @@
           this.set_alttext('delete', 'movemessagetotrash');
 
+        this.env.message_commands = ['show', 'reply', 'reply-all', 'forward', 'moveto', 'copy', 'delete',
+          'open', 'mark', 'edit', 'viewsource', 'download', 'print', 'load-attachment', 'load-headers'];
+
         if (this.env.action=='show' || this.env.action=='preview') {
-          this.enable_command('show', 'reply', 'reply-all', 'forward', 'moveto', 'copy', 'delete',
-            'open', 'mark', 'edit', 'viewsource', 'download', 'print', 'load-attachment', 'load-headers', true);
+          this.enable_command(this.env.message_commands, true);
 
           if (this.env.next_uid) {
@@ -1048 +1050 @@
   };
 
-  // set command enabled or disabled
+  // set command(s) enabled or disabled
   this.enable_command = function()
   {
-    var args = arguments, len = args.length;
-    if (!len)
-      return -1;
-
-    var command, enable = args[len-1];
+    var args = arguments, len = args.length,
+      command, enable = args[len-1];
 
     for (var n=0, len=len-1; n<len; n++) {
+      if (typeof args[n] === 'object') {
+        for (var i in args[n])
+          this.enable_command(args[n][i], enable);
+        continue;
+      }
       command = args[n];
       this.commands[command] = enable;
       this.set_button(command, (enable ? 'act' : 'pas'));
     }
-    return true;
   };
 
@@ -1399 +1402 @@
     var selected = list.get_single_selection() != null;
 
+    this.enable_command(this.env.message_commands, selected);
     // Hide certain command buttons when Drafts folder is selected
-    this.enable_command('reply', 'reply-all', 'forward', this.env.mailbox == this.env.drafts_mailbox ? false : selected);
-    this.enable_command('show', 'print', 'open', 'edit', 'download', 'viewsource', selected);
+    if (selected && this.env.mailbox == this.env.drafts_mailbox) {
+      this.enable_command('reply', 'reply-all', 'forward', false);
+    }
+    // Multi-message commands
     this.enable_command('delete', 'moveto', 'copy', 'mark', (list.selection.length > 0 ? true : false));
 
@@ -2326 +2332 @@
 
     // Hide message command buttons until a message is selected
-    this.enable_command('reply', 'reply-all', 'forward', 'delete', 'mark', 'print', 'open', 'edit', 'viewsource', 'download', false);
+    this.enable_command(this.env.message_commands, false);
 
     this._with_selected_messages('moveto', lock, add_url);
@@ -4931 +4937 @@
       for (var i=0; i < response.callbacks.length; i++)
         this.triggerEvent(response.callbacks[i][0], response.callbacks[i][1]);
+    }
 
     // process the response data according to the sent action
@@ -4945 +4952 @@
         if (this.env.action == 'show') {
           // re-enable commands on move/delete error
-          this.enable_command('reply', 'reply-all', 'forward', 'delete', 'mark', 'print', 'open', 'edit', 'viewsource', 'download', true);
+          this.enable_command(this.env.message_commands, true);
         }
         break;
@@ -4956 +4963 @@
             this.show_contentframe(false);
           // disable commands useless when mailbox is empty
-          this.enable_command('show', 'reply', 'reply-all', 'forward', 'moveto', 'copy', 'delete',
-            'mark', 'viewsource', 'open', 'edit', 'download', 'print', 'load-attachment',
+          this.enable_command(this.env.message_commands,
             'purge', 'expunge', 'select-all', 'select-none', 'sort',
             'expand-all', 'expand-unread', 'collapse-all', false);