Changeset 1246 in subversion

Timestamp:

Apr 4, 2008 2:59:07 AM (5 years ago)

Author:

alec

Message:

improved r1213 change: removed redundant code
and used mark_message() instead of toggle_read_status()
(which should be used only inside mark_message() function)

File:

• trunk/roundcubemail/program/js/app.js (modified) (7 diffs)

trunk/roundcubemail/program/js/app.js

@@ -893 +893 @@
             setTimeout(function(){ ref.printwin.focus(); }, 20);
             if (this.env.action != 'show')
-              this.toggle_read_status('read', [uid]);
+              this.mark_message('read', uid);
           }
         }
@@ -1487 +1487 @@
     {
     var a_uids = new Array();
+    var r_uids = new Array();
     var selection = this.message_list ? this.message_list.get_selection() : new Array();
     
@@ -1497 +1498 @@
       for (var id, n=0; n<selection.length; n++)
         {
-        id = selection[n];
-        if ((flag=='read' && this.message_list.rows[id].unread) || (flag=='unread' && !this.message_list.rows[id].unread)
-            || (flag=='delete' && !this.message_list.rows[id].deleted) || (flag=='undelete' && this.message_list.rows[id].deleted))
-          a_uids[a_uids.length] = id;
-        }
+          a_uids[a_uids.length] = selection[n];
+        }
+      }
+
+    for (var id, n=0; n<a_uids.length; n++)
+      {
+        id = a_uids[n];
+        if ((flag=='read' && this.message_list.rows[id].unread) 
+            || (flag=='unread' && !this.message_list.rows[id].unread)
+            || (flag=='delete' && !this.message_list.rows[id].deleted)
+            || (flag=='undelete' && this.message_list.rows[id].deleted))
+          {
+            r_uids[r_uids.length] = id;
+          }
       }
     
     // nothing to do
-    if (!a_uids.length)
+    if (!r_uids.length)
       return;
       
@@ -1512 +1522 @@
         case 'read':
         case 'unread':
-          this.toggle_read_status(flag, a_uids);
+          this.toggle_read_status(flag, r_uids);
           break;
         case 'delete':
         case 'undelete':
-          this.toggle_delete_status(a_uids);
+          this.toggle_delete_status(r_uids);
           break;
       }
@@ -1526 +1536 @@
     // mark all message rows as read/unread
     var icn_src;
-    var res_uids = new Array(); 
     var rows = this.message_list.rows;
     for (var i=0; i<a_uids.length; i++)
       {
       uid = a_uids[i];
-      // check if flag isn't set yet 
-      if (rows[uid] && ((flag=='unread' && !rows[uid].unread) || (flag=='read' && rows[uid].unread)))
-        {
-        res_uids[res_uids.length] = uid;
-
+      if (rows[uid])
+        {
         rows[uid].unread = (flag=='unread' ? true : false);
         
@@ -1562 +1568 @@
       }
 
-    if (res_uids.length)
-      this.http_post('mark', '_uid='+res_uids.join(',')+'&_flag='+flag);
+    this.http_post('mark', '_uid='+a_uids.join(',')+'&_flag='+flag);
   };
   
@@ -1570 +1575 @@
   {
     if (this.env.read_when_deleted)
-      this.toggle_read_status('read',a_uids);
+      this.mark_message('read',a_uids);
 
     // if deleting message from "view message" don't bother with delete icon