Changeset 0e11940 in github

Timestamp:

Dec 6, 2010 9:06:44 AM (2 years ago)

Author:

alecpl <alec@…>

Branches:

master, HEAD, courier-fix, dev-browser-capabilities, pdo, release-0.6, release-0.7, release-0.8

Children:

d7e83d3

Parents:

7472893

Message:

• Improve performance of folder rename and delete actions. Don't get list of all folders when we need only children of the specified folder.

Files:

• CHANGELOG (modified) (1 diff)
• program/include/rcube_imap.php (modified) (7 diffs)
• program/steps/settings/folders.inc (modified) (2 diffs)

CHANGELOG

@@ -16 +16 @@
 - Improve performance of moving or copying of all messages in a folder
 - Fix plaintext versions of HTML messages don't contain placeholders for emotions (#1485206)
+- Improve performance of folder rename and delete actions
 
 RELEASE 0.5-BETA

program/include/rcube_imap.php

@@ -3019 +3019 @@
      * Get mailbox size (size of all messages in a mailbox)
      *
-     * @param string $name Mailbox name    
+     * @param string $name Mailbox name
      * @return int Mailbox size in bytes, False on error
      */
@@ -3094 +3094 @@
      * @param string $mbox_name Mailbox to rename
      * @param string $new_name  New mailbox name
+     *
      * @return boolean True on success
      */
@@ -3103 +3104 @@
         $mailbox  = $this->mod_mailbox($mbox_name);
         $abs_name = $this->mod_mailbox($new_name);
-
-        // check if mailbox is subscribed
-        $a_subscribed = $this->_list_mailboxes();
-        $subscribed   = in_array($mailbox, $a_subscribed);
-
-        // unsubscribe folder
-        if ($subscribed)
-            $this->conn->unsubscribe($mailbox);
+        $delm     = $this->get_hierarchy_delimiter();
+
+        // get list of subscribed folders
+        if ((strpos($mailbox, '%') === false) && (strpos($mailbox, '*') === false)) {
+            $a_subscribed = $this->_list_mailboxes('', $mbox_name . $delm . '*');
+            $subscribed   = $this->mailbox_exists($mbox_name, true);
+        }
+        else {
+            $a_subscribed = $this->_list_mailboxes();
+            $subscribed   = in_array($mailbox, $a_subscribed);
+        }
 
         if (strlen($abs_name))
@@ -3116 +3120 @@
 
         if ($result) {
-            $delm = $this->get_hierarchy_delimiter();
+            // unsubscribe the old folder, subscribe the new one
+            if ($subscribed) {
+                $this->conn->unsubscribe($mailbox);
+                $this->conn->subscribe($abs_name);
+            }
 
             // check if mailbox children are subscribed
-            foreach ($a_subscribed as $c_subscribed)
+            foreach ($a_subscribed as $c_subscribed) {
                 if (preg_match('/^'.preg_quote($mailbox.$delm, '/').'/', $c_subscribed)) {
                     $this->conn->unsubscribe($c_subscribed);
@@ -3125 +3133 @@
                         $abs_name, $c_subscribed));
                 }
+            }
 
             // clear cache
@@ -3131 +3140 @@
         }
 
-        // try to subscribe it
-        if ($result && $subscribed)
-            $this->conn->subscribe($abs_name);
-
         return $result;
     }
@@ -3140 +3145 @@
 
     /**
-     * Remove mailboxes from server
-     *
-     * @param string|array $mbox_name Mailbox name(s) string/array
+     * Remove mailbox from server
+     *
+     * @param string $mbox_name Mailbox name
+     *
      * @return boolean True on success
      */
     function delete_mailbox($mbox_name)
     {
-        $deleted = false;
-
-        if (is_array($mbox_name))
-            $a_mboxes = $mbox_name;
-        else if (is_string($mbox_name) && strlen($mbox_name))
-            $a_mboxes = explode(',', $mbox_name);
-
-        if (is_array($a_mboxes)) {
-            $delimiter = $this->get_hierarchy_delimiter();
-        
-            foreach ($a_mboxes as $mbox_name) {
-                $mailbox = $this->mod_mailbox($mbox_name);
-                $sub_mboxes = $this->conn->listMailboxes('', $mbox_name . $delimiter . '*');
-
-                // unsubscribe mailbox before deleting
-                $this->conn->unsubscribe($mailbox);
-
-                // send delete command to server
-                $result = $this->conn->deleteFolder($mailbox);
-                if ($result) {
-                    $deleted = true;
-                    $this->clear_message_cache($mailbox.'.msg');
-                    }
-
-                foreach ($sub_mboxes as $c_mbox) {
-                    if ($c_mbox != 'INBOX') {
-                        $this->conn->unsubscribe($c_mbox);
-                        $result = $this->conn->deleteFolder($c_mbox);
-                        if ($result) {
-                            $deleted = true;
-                            $this->clear_message_cache($c_mbox.'.msg');
-                        }
+        $result  = false;
+        $mailbox = $this->mod_mailbox($mbox_name);
+        $delm    = $this->get_hierarchy_delimiter();
+
+        // get list of folders
+        if ((strpos($mailbox, '%') === false) && (strpos($mailbox, '*') === false))
+            $sub_mboxes = $this->list_unsubscribed('', $mailbox . $delm . '*');
+        else
+            $sub_mboxes = $this->list_unsubscribed();
+
+        // send delete command to server
+        $result = $this->conn->deleteFolder($mailbox);
+
+        if ($result) {
+            // unsubscribe mailbox
+            $this->conn->unsubscribe($mailbox);
+
+            foreach ($sub_mboxes as $c_mbox) {
+                if (preg_match('/^'.preg_quote($mailbox.$delm, '/').'/', $c_mbox)) {
+                    $this->conn->unsubscribe($c_mbox);
+                    if ($this->conn->deleteFolder($c_mbox)) {
+                            $this->clear_message_cache($c_mbox.'.msg');
                     }
                 }
             }
-        }
-
-        // clear mailboxlist cache
-        if ($deleted)
+
+            // clear mailbox-related cache
+            $this->clear_message_cache($mailbox.'.msg');
             $this->clear_cache('mailboxes');
-
-        return $deleted;
+        }
+
+        return $result;
     }
 

program/steps/settings/folders.inc

@@ -66 +66 @@
 else if ($RCMAIL->action == 'delete-folder')
 {
-    $a_mboxes  = $IMAP->list_unsubscribed();
-    $delimiter = $IMAP->get_hierarchy_delimiter();
-  
     $mbox_utf8 = get_input_value('_mbox', RCUBE_INPUT_POST, true);
     $mbox      = rcube_charset_convert($mbox_utf8, RCMAIL_CHARSET, 'UTF7-IMAP');
 
+    // get folder's children or all folders if the name contains special characters
+    $delimiter = $IMAP->get_hierarchy_delimiter();
+    if ((strpos($mbox, '%') === false) && (strpos($mbox, '*') === false))
+        $a_mboxes  = $IMAP->list_unsubscribed('', $mbox.$delimiter.'*');
+    else
+        $a_mboxes  = $IMAP->list_unsubscribed();
+
     if (strlen($mbox))
-        $deleted = $IMAP->delete_mailbox(array($mbox));
+        $deleted = $IMAP->delete_mailbox($mbox);
 
     if ($OUTPUT->ajax_call && $deleted) {
-        // Remove folder rows
+        // Remove folder and subfolders rows
         $OUTPUT->command('remove_folder_row', $mbox_utf8);
         foreach ($a_mboxes as $folder) {
@@ -122 +126 @@
 
                 $before = isset($folderlist[$x+1]) ? rcube_charset_convert($folderlist[$x+1], 'UTF7-IMAP') : false;
-        
+
                 $OUTPUT->command('replace_folder_row', rcube_charset_convert($oldfolder, 'UTF7-IMAP'),
                     rcube_charset_convert($folderlist[$x], 'UTF7-IMAP'), $display_rename, $before);