Changeset 0ced2b9 in github

Timestamp:

Aug 22, 2008 5:58:48 AM (5 years ago)

Author:

thomascube <thomas@…>

Branches:

master, HEAD, courier-fix, dev-browser-capabilities, pdo, release-0.6, release-0.7, release-0.8

Children:

26f5b09

Parents:

f74b283

Message:

Revert r1670 but improve part download step by fixing headers and adding set_time_limit(0)

Location:

program

Files:

• include/rcube_browser.php (modified) (1 diff)
• steps/mail/get.inc (modified) (4 diffs)

program/include/rcube_browser.php

@@ -39 +39 @@
         $this->unix  = stristr($HTTP_USER_AGENT, 'unix');
 
+        $this->opera = stristr($HTTP_USER_AGENT, 'opera');
         $this->ns4 = stristr($HTTP_USER_AGENT, 'mozilla/4') && !stristr($HTTP_USER_AGENT, 'msie');
         $this->ns  = ($this->ns4 || stristr($HTTP_USER_AGENT, 'netscape'));
-        $this->ie  = stristr($HTTP_USER_AGENT, 'msie');
+        $this->ie  = stristr($HTTP_USER_AGENT, 'compatible; msie') && !$this->opera;
         $this->mz  = stristr($HTTP_USER_AGENT, 'mozilla/5');
-        $this->opera = stristr($HTTP_USER_AGENT, 'opera');
         $this->safari = stristr($HTTP_USER_AGENT, 'safari');
 

program/steps/mail/get.inc

@@ -55 +55 @@
     $ctype_secondary = strtolower($part->ctype_secondary);
     $mimetype = sprintf('%s/%s', $ctype_primary, $ctype_secondary);
+    
+    $browser = new rcube_browser;
 
     header("Expires: 0");
@@ -63 +65 @@
     // send download headers
     if ($_GET['_download']) {
-      header("Cache-Control: private", false);
       header("Content-Type: application/octet-stream");
+      if ($browser->ie)
+        header("Content-Type: application/force-download");
     }
     else if ($ctype_primary == 'text')
-      header("Content-Type: text/$ctype_secondary; charset=" . RCMAIL_CHARSET);
+      header("Content-Type: text/$ctype_secondary; charset=" . ($part->charset ? $part->charset : RCMAIL_CHARSET));
     else
       header("Content-Type: $mimetype");
@@ -79 +82 @@
     // deliver part content
     if ($ctype_primary == 'text' && $ctype_secondary == 'html') {
-      // we have to analyze the whole structure again to find inline objects
-      /* what was this good for again ?
-      list($new_parts, $new_attachments) =
-        rcmail_parse_message($MESSAGE['structure'],
-                             array('safe' => intval($_GET['_safe']),
-                                   'prefer_html' => TRUE,
-                                   'get_url' => $GET_URL.'&_part=%s'));
-
-      $all_parts = array_merge($new_parts, $new_attachments);
-      for ($partix = 0; $partix < sizeof($all_parts); $partix++)
-        if ($all_parts[$partix]->mime_id == $pid)
-          $part = &$all_parts[$partix];
-      */
-
       // get part body if not available
       if (!$part->body)
@@ -101 +90 @@
     }
     else {
-      header(sprintf('Content-Length: %d', $part->size));
-      header(sprintf('Content-Disposition: %s; filename="%s";',
-                     $_GET['_download'] ? 'attachment' : 'inline',
-                     $part->filename ? abbreviate_string($part->filename, 55) : "roundcube.$ctype_secondary"));
+      // don't kill the connection if download takes more than 30 sec.
+      if (!ini_get('safe_mode')) {
+          set_time_limit(0);
+      }
+      
+      $filename = $part->filename ? $part->filename : ($MESSAGE->subject ? $MESSAGE->subject : 'roundcube') . '.'.$ctype_secondary;
+      $filename = abbreviate_string($part->filename, 55);
+      $filename = $browser->ie ? rawurlencode($filename) : addslashes($filename);
+      $disposition = !empty($_GET['_download']) ? 'attachment' : 'inline';
+      
+      header("Content-Disposition: $disposition; filename=\"$filename\"");
 
       // turn off output buffering and print part content